Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Fix Day trader analysis failure #185

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Conversation

nachandr
Copy link
Collaborator

No description provided.

Signed-off-by: Nandini Chandra <[email protected]>
@nachandr
Copy link
Collaborator Author

nachandr commented Oct 12, 2024

API_PR_185

Screen shot of the Jenkins run that shows that the analysis of the day trader app passed

Copy link
Collaborator

@mguetta1 mguetta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nachandr thanks for the PR. Could you please add issue incidents as well?

@nachandr nachandr changed the title [RFR] Fix Day trader analysis [RFR] Fix Day trader analysis failure Oct 14, 2024
Signed-off-by: Nandini Chandra <[email protected]>
@nachandr
Copy link
Collaborator Author

Hi @nachandr thanks for the PR. Could you please add issue incidents as well?

Issue incidents have been added.

analysis/tc_daytrader.go Show resolved Hide resolved
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mguetta1 mguetta1 added the cherry-pick/release-0.5 This PR should be cherry-picked to release-0.5 branch. label Oct 26, 2024
@nachandr nachandr merged commit 5348585 into konveyor:main Oct 28, 2024
6 of 7 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 28, 2024
* Fix Day trader analysis

Signed-off-by: Nandini Chandra <[email protected]>

* Adding incidents for issues

Signed-off-by: Nandini Chandra <[email protected]>

* Add messages for Incidents

Signed-off-by: Nandini Chandra <[email protected]>

* Add messages for Incidents

Signed-off-by: Nandini Chandra <[email protected]>

---------

Signed-off-by: Nandini Chandra <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.5 This PR should be cherry-picked to release-0.5 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants