👻 Refactor tags table to remove deprecated legacy table dep

konveyor · Mar 29, 2024 · ce9b406 · ce9b406
1 parent 7f7375a
commit ce9b406
Show file tree

Hide file tree

Showing 4 changed files with 286 additions and 305 deletions.
diff --git a/client/public/locales/en/translation.json b/client/public/locales/en/translation.json
@@ -220,7 +220,9 @@
     "toTagApplication": "Either no tags exist yet or you may not have permission to view any. If you have permission, try creating a new custom tag.",
     "unsavedChanges": "Are you sure you want to close the assessment? Any unsaved changes will be lost.",
     "noAnswers": "Are you sure you want to close the assessment? There are no answers to save.",
-    "unlinkTicket": "Unlink from Jira"
+    "unlinkTicket": "Unlink from Jira",
+    "noTagsAvailable": "No tags available",
+    "noAssociatedTags": "This tag category has no associated tags."
   },
   "proposedActions": {
     "refactor": "Refactor",

diff --git a/client/src/app/components/labels/item-tag-label/item-tag-label.tsx b/client/src/app/components/labels/item-tag-label/item-tag-label.tsx
@@ -3,7 +3,7 @@ import { Tag, TagCategory } from "@app/api/models";
 import { COLOR_HEX_VALUES_BY_NAME } from "@app/Constants";
 import { LabelCustomColor } from "@app/components/LabelCustomColor";
 
-export const getTagCategoryFallbackColor = (category?: TagCategory) => {
+export const getTagCategoryFallbackColor = (category?: TagCategory | null) => {
   if (!category?.id) return COLOR_HEX_VALUES_BY_NAME.gray;
   const colorValues = Object.values(COLOR_HEX_VALUES_BY_NAME);
   return colorValues[category?.id % colorValues.length];

diff --git a/client/src/app/pages/controls/tags/components/tag-table.tsx b/client/src/app/pages/controls/tags/components/tag-table.tsx
@@ -9,8 +9,6 @@ import {
   Td,
   ActionsColumn,
   IAction,
-  cellWidth,
-  ICell,
   IRow,
   IRowData,
 } from "@patternfly/react-table";
@@ -36,17 +34,6 @@ export const TagTable: React.FC<TabTableProps> = ({
 }) => {
   const { t } = useTranslation();
 
-  const columns: ICell[] = [
-    {
-      title: t("terms.tagName"),
-      transforms: [cellWidth(100)],
-      cellFormatters: [],
-      props: {
-        className: "columnPadding",
-      },
-    },
-  ];
-
   const rows: IRow[] = [];
   (tagCategory.tags || [])
     .sort((a, b) => a.name.localeCompare(b.name))
@@ -94,9 +81,7 @@ export const TagTable: React.FC<TabTableProps> = ({
           const rowActions = defaultActions(row);
           return (
             <Tr>
-              {row.cells?.map((cell: any) => (
-                <Td>{cell.title}</Td>
-              ))}
+              {row.cells?.map((cell: any) => <Td>{cell.title}</Td>)}
               <Td isActionCell>
                 {rowActions && <ActionsColumn items={rowActions} />}
               </Td>