Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize on which form of (byID || byId) to use #1307

Closed
ibolton336 opened this issue Aug 23, 2023 · 3 comments · Fixed by #1482
Closed

Standardize on which form of (byID || byId) to use #1307

ibolton336 opened this issue Aug 23, 2023 · 3 comments · Fixed by #1482
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@ibolton336
Copy link
Member

We aren't consistent about this elsewhere-> we should choose between ...ByID and ...ById and stick with it.

https://stackoverflow.com/questions/15526107/acronyms-in-camelcase
@ibolton336 ibolton336 added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Aug 23, 2023
@ibolton336 ibolton336 mentioned this issue Aug 23, 2023
Merged
@sarthaksarthak9
Copy link
Contributor

@ibolton336 is this issue is still open?

@ibolton336
Copy link
Member Author

@ibolton336 is this issue is still open?

Appears that we have since settled on "ID->Id". There are still a few places where we need to reflect this decision in the code. E.g. getKindIDByRef, useFetchBusinessServiceByID, etc. @sarthaksarthak9

@sarthaksarthak9
Copy link
Contributor

@ibolton336 ok!!

@sarthaksarthak9 sarthaksarthak9 mentioned this issue Oct 17, 2023
Merged
sjd78 pushed a commit that referenced this issue Oct 19, 2023
@sarthaksarthak9
✨ refelect ID -> Id (#1482)
e910613 
Appears that konveyor have since settled on "ID->Id". There are still a
few places where we need to reflect this decision in the code. E.g.
getKindIDByRef, useFetchBusinessServiceByID, etc

closes #1307

---------

Signed-off-by: sarthaksarthak9 <[email protected]>
Signed-off-by: Sarthak Negi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ refelect ID -> Id sarthaksarthak9/tackle2-ui
2 participants
@ibolton336 @sarthaksarthak9