Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Refactor CI github actions, Dockerfile #1780

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented Mar 15, 2024

Refactoring:

  • Split CI, one for repo tests and one for global tests

  • Only enable global CI on main (with a note)

  • Global CI configured like the multiarch build to cancel in progress runs in a new run starts

  • Repo CI bump the version of action codecov/codecov-action based on runtime warnings

  • Add --ignoreScripts to the npm clean-install in the Dockerfile to avoid running unnecessary postinstall scripts with the build running directly after the install.

Refactoring:
  - Split CI, one for repo tests and one for global tests

  - Only enable global CI on main (with a note)

  - Global CI configured like the multiarch build to cancel
    in progress runs in a new run starts

  - Repo CI bump the version of action `codecov/codecov-action`
    based on runtime warnings

  - Add `--ignoreScripts` to the `npm clean-install` in the Dockerfile
    to avoid running unnecessary postinstall scripts with the build
    running directly after the install.

Signed-off-by: Scott J Dickerson <[email protected]>
@sjd78 sjd78 added this to the v0.3.1 milestone Mar 15, 2024
@sjd78 sjd78 added the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Mar 15, 2024
@rszwajko
Copy link
Collaborator

Looks OK to me.

Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visack

@sjd78 sjd78 merged commit 94a04a3 into konveyor:main Mar 18, 2024
6 checks passed
@sjd78 sjd78 deleted the refactor_ci branch March 18, 2024 15:58
github-actions bot pushed a commit that referenced this pull request Mar 18, 2024
Refactoring:
  - Split CI, one for repo tests and one for global tests

  - Only enable global CI on main (with a note)

  - Global CI configured like the multiarch build to cancel in progress
    runs if a new run starts

  - Repo CI bump the version of action `codecov/codecov-action` based on
    runtime warnings

  - Add `--ignoreScripts` to the `npm clean-install` in the Dockerfile to
    avoid running unnecessary postinstall scripts with the build running
    directly after the install.

Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
sjd78 added a commit that referenced this pull request Mar 19, 2024
Refactoring:
  - Split CI, one for repo tests and one for global tests

  - Only enable global CI on main (with a note)

  - Global CI configured like the multiarch build to cancel in progress
    runs if a new run starts

  - Repo CI bump the version of action `codecov/codecov-action` based on
    runtime warnings

  - Add `--ignoreScripts` to the `npm clean-install` in the Dockerfile to
    avoid running unnecessary postinstall scripts with the build running
    directly after the install.

Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Scott Dickerson <[email protected]>
sjd78 added a commit to sjd78/tackle2-ui that referenced this pull request Apr 22, 2024
Backport image build changes made on main and release-0.3
to get release-0.2 building properly.

See: konveyor#1781, konveyor#1780
Follow-up to konveyor#1801, konveyor#1871

Signed-off-by: Scott J Dickerson <[email protected]>
sjd78 added a commit to sjd78/tackle2-ui that referenced this pull request Apr 22, 2024
Backport image build changes made on main and release-0.3
to get release-0.2 building properly.

See: konveyor#1781, konveyor#1780
Follow-up to konveyor#1801, konveyor#1871

Signed-off-by: Scott J Dickerson <[email protected]>
sjd78 added a commit that referenced this pull request Apr 30, 2024
Backport image build changes made on main and release-0.3 to get
release-0.2 building properly.

See: #1781, #1780
Follow-up to #1801, #1871

---------

Signed-off-by: Scott J Dickerson <[email protected]>
sjd78 added a commit to sjd78/konveyor-ci that referenced this pull request May 3, 2024
Replace the UI CI workflow badge with the currently correct
workflow.  The row for the UI component was using a workflow
that was removed with konveyor/tackle2-ui#1780.

Signed-off-by: Scott J Dickerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants