✨ Add cancel option for multiple analyses #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiriSafra
force-pushed
the
shevi_miri_feature/cancel-multiple-analyses
branch
from
55a4d7a to
cf9e79e
Compare
MiriSafra
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2099 +/- ##
==========================================
+ Coverage 39.20% 41.98% +2.78%
==========================================
Files 146 175 +29
Lines 4857 5630 +773
Branches 1164 1341 +177
==========================================
+ Hits 1904 2364 +460
- Misses 2939 3250 +311
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MiriSafra
requested review from
ibolton336,
sjd78 and
rszwajko
as code owners
MiriSafra
force-pushed
the
shevi_miri_feature/cancel-multiple-analyses
branch
2 times, most recently
from
d8c2bb5 to
09d2827
Compare
Signed-off-by: MiriSafra <[email protected]>
MiriSafra
force-pushed
the
shevi_miri_feature/cancel-multiple-analyses
branch
from
09d2827 to
3302462
Compare
Signed-off-by: MiriSafra <[email protected]>
Signed-off-by: MiriSafra <[email protected]>
MiriSafra
changed the title
rszwajko
requested changes
Oct 29, 2024
client/src/app/pages/applications/applications-table/applications-table.tsx
Outdated
Show resolved
Hide resolved
client/src/app/pages/applications/applications-table/applications-table.tsx
Show resolved
Hide resolved
client/src/app/pages/applications/applications-table/applications-table.tsx
Show resolved
Hide resolved
Signed-off-by: MiriSafra <[email protected]>
Signed-off-by: shevijacobson <[email protected]>
…ltiple-analyses 🐛 fix confirm dialog
rszwajko
approved these changes
Oct 30, 2024
sjd78
requested changes
Oct 30, 2024
sjd78
reviewed
Oct 30, 2024
client/src/app/pages/applications/applications-table/applications-table.tsx
Show resolved
Hide resolved
Signed-off-by: MiriSafra <[email protected]>
MiriSafra
commented
Oct 30, 2024
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for cancelling multiple analyses simultaneously. Integrated functionality into the actions menu for bulk applications.
Resolves: https://issues.redhat.com/browse/MTA-3639
New Bulk Cancel Analyses Button
Cancel Analyses Button Disabled When No Applications Are Selected
Cancel Analyses Button Disabled When No Running Analyses Are Selected
Confirm Dialog Triggered on Cancel Analyses Button Click
Action Cancels All Running Analyses for Selected Applications