Skip to content
This repository has been archived by the owner on Apr 17, 2024. It is now read-only.

Allow use of existing secrets #53

Closed
jon-rei opened this issue Oct 6, 2023 · 3 comments · Fixed by #54
Closed

Allow use of existing secrets #53

jon-rei opened this issue Oct 6, 2023 · 3 comments · Fixed by #54

Comments

@jon-rei
Copy link

jon-rei commented Oct 6, 2023

It would be great if we could use existing secrets for the exporter.
In our environment we use SealedSecrets to create our secrets. So it would be great if an existing secret could be passed to the helm chart for the rgw configuration.
galexrt added a commit that referenced this issue Oct 10, 2023
@galexrt
helm: add option to use an existing secret for rgw credentials
0a3e60b 
Resolves #53

Signed-off-by: Alexander Trost <[email protected]>
@galexrt
Copy link
Member

galexrt commented Oct 10, 2023 •
edited
Loading

@jon-rei Good point, I think we will probably make it so that if a secret is given it will use that for the exporter and if enabled the post install job.

I have opened #54 to add this functionality.

galexrt added a commit that referenced this issue Oct 10, 2023
@galexrt
helm: add option to use an existing secret for rgw credentials
37eb6fc 
Resolves #53

Signed-off-by: Alexander Trost <[email protected]>
@galexrt galexrt mentioned this issue Oct 10, 2023
Merged
galexrt added a commit that referenced this issue Oct 10, 2023
@galexrt
helm: add option to use an existing secret for rgw credentials
2aa5979 
Resolves #53

Signed-off-by: Alexander Trost <[email protected]>
galexrt added a commit that referenced this issue Oct 10, 2023
@galexrt
helm: add option to use an existing secret for rgw credentials
8325450 
Resolves #53

Signed-off-by: Alexander Trost <[email protected]>
galexrt added a commit that referenced this issue Oct 11, 2023
@galexrt
helm: add option to use an existing secret for rgw credentials (#54)
438c6ce 
Resolves #53

Signed-off-by: Alexander Trost <[email protected]>
@galexrt
Copy link
Member

galexrt commented Oct 11, 2023

@jon-rei please try with the latest helm chart version 1.3.0 and let us know if that works for you

@jon-rei
Copy link
Author

jon-rei commented Oct 13, 2023

Hi @galexrt, I've just deployed the new version on our cluster and it works, thanks for the quick implementation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

helm: add option to use an existing secret for rgw credentials koor-tech/extended-ceph-exporter
2 participants
@galexrt @jon-rei