Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator crashes executing z80tests.tap #24

Open
jsanchezv opened this issue Nov 6, 2021 · 5 comments
Open

Emulator crashes executing z80tests.tap #24

jsanchezv opened this issue Nov 6, 2021 · 5 comments
Labels

Comments

@jsanchezv
Copy link

Hi,

Trying your emulator I've found that crashes executing the Mark Woodmass z80tests.tap with:

python3: zx/../z80/z80.h:948: void z80::z80_decoder::on_decode_ed_prefix() [with B = z80::z80_state<z80::root<{anonymous}::Spectrum48::machine_emulator> >]: La declaración `0' no se cumple.

I'm using Fedora 34, Python 3.9.7, G++ 11.2.1.

I attach the test:
z80tests.tap.gz

Thanks for your work.
José Luis

kosarev added a commit that referenced this issue Nov 7, 2021
@kosarev kosarev added the bug label Nov 7, 2021
@kosarev
Copy link
Owner

kosarev commented Nov 7, 2021

How interesting. I even had the test, but somehow didn't run it against the latest Z80 versions. Thanks for pointing out!

Now, 6f72f45 resolves the crash, but the test still reports failures. I will need to look into this.

@kosarev
Copy link
Owner

kosarev commented Nov 7, 2021

@jsanchezv Hi José, do you know anything about the origin of the test? Any chance the source code is available? Thanks.

@jsanchezv
Copy link
Author

Hi Ivan,

Mark Woodmass don't publish his sources. But, beware, Mark test his program using a NEC Z80 CPU, not a Zilog, so a few tests fails when you uses an emulated Zilog Z80. For a better test, use the z80test-1.0 from Patrick Rak (from the ZXDS hall of fame). His tests comes with source code.

@kosarev
Copy link
Owner

kosarev commented Nov 7, 2021

This seems to be the test from Patrik Rak:
https://github.com/raxoft/z80test

@jsanchezv
Copy link
Author

Correct, are the best tests you can find about the Z80, IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants