-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Abondoned for commit too large】:decoupling apiserver and clustersynchro-manager by message midd… #1
base: main
Are you sure you want to change the base?
Conversation
@@ -45,13 +51,32 @@ type Options struct { | |||
KubeStateMetrics *kubestatemetrics.Options | |||
|
|||
WorkerNumber int // WorkerNumber is the number of worker goroutines | |||
Publisher *watchoptions.MiddlerwareOptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
middleware to messagequeue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
middleware better
|
||
options.BindLeaderElectionFlags(&o.LeaderElection, genericfs) | ||
|
||
fs := fss.FlagSet("misc") | ||
fs.StringVar(&o.Master, "master", o.Master, "The address of the Kubernetes API server (overrides any value in kubeconfig).") | ||
fs.StringVar(&o.Kubeconfig, "kubeconfig", o.Kubeconfig, "Path to kubeconfig file with authorization and master location information.") | ||
fs.StringVar(&o.Kubeconfig, "manager-kubeconfig", o.Kubeconfig, "Path to kubeconfig file with authorization and master location information.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you modify the current kueconfig key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i will fix it.
"strings" | ||
) | ||
|
||
func GetShardingTable(gvr schema.GroupVersionResource) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does GetShardingTable work for
please run make lint on your local Desktop |
1eb08d9
to
4177173
Compare
7eebc7d
to
21084f6
Compare
…leware Signed-off-by: zhouhaoA1 <[email protected]>
21084f6
to
8538dc6
Compare
d799fb3
to
bf2a5d5
Compare
…leware
What type of PR is this?
/kind feature
What this PR does / why we need it:
decoupling apiserver and clustersynchro-manager by message middware
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: