Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore GeoPoint support #73

Open
zomble opened this issue Oct 30, 2020 · 2 comments
Open

Firestore GeoPoint support #73

zomble opened this issue Oct 30, 2020 · 2 comments

Comments

@zomble
Copy link

zomble commented Oct 30, 2020

The admin.firestore.GeoPoint class is returned for the geopoint type.

The wrapData function converts it to a plain object. e.g { _latitude: -1.323, _longitude: 23.5342 }.

I would at least prefer to see { latitude: -1.323, longitude: 23.5342 }. Though having access to the GeoPoint class as intended would also be nice.

Something like the following will be part of the change required:

} else if (data instanceof adaptor.consts.GeoPoint) {
  return data // what should we do here?
} 

How should typesaurus handle this type?

@LucioBevilacqua
Copy link

I'm having the same issue, did you manage to solve it?

@kossnocorp
Copy link
Owner

It's not supported yet, and I never worked with it, but I think it's worth adding. Please let me know if anyone has a use case or idea of how to make it nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants