Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview in BasicColorPicker should be optional #340

Closed
cypherdare opened this issue Sep 16, 2020 · 1 comment · Fixed by #342
Closed

Preview in BasicColorPicker should be optional #340

cypherdare opened this issue Sep 16, 2020 · 1 comment · Fixed by #342
Labels
enhancement ui

Comments

@cypherdare
Copy link
Contributor

cypherdare commented Sep 16, 2020 •
edited
Loading

As-is, the BasicColorPicker is designed for use in a dialog or pop-up. If you just want to use it persistently on a screen and see immediate results, like I'm doing here, then you want to hide the preview.

If you're open to it, I can make a PR.
@kotcrab
Copy link
Owner

kotcrab commented Sep 22, 2020

I agree, you can make PR for it. Should be pretty easy.

cypherdare added a commit to cypherdare/vis-ui that referenced this issue Sep 22, 2020
@cypherdare
Add BasicColorPicker.setShowColorPreviews()
068a3ef 
Closes kotcrab#340
@cypherdare cypherdare mentioned this issue Sep 22, 2020
Merged
kotcrab pushed a commit that referenced this issue Sep 23, 2020
@cypherdare
Add BasicColorPicker.setShowColorPreviews() (#342)
ae496eb 
Closes #340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add BasicColorPicker.setShowColorPreviews() cypherdare/vis-ui
2 participants
@cypherdare @kotcrab