Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing and CI #53

Open
2 of 4 tasks
rye opened this issue Jun 6, 2017 · 9 comments
Open
2 of 4 tasks

Testing and CI #53

rye opened this issue Jun 6, 2017 · 9 comments

Comments

@rye
Copy link
Member

rye commented Jun 6, 2017

I think we should really look into improving some of the ways we interact with users. We should try to deal with edge cases in a smarter way, and generally clean up our code. How do we feel about using CI and tests? Testing our existing code might evoke good change in our codebase.

Task List:

@cg505
Copy link
Contributor

cg505 commented Jun 6, 2017

I'm doing research rn on the best approach for testing. We also should get linting set up and put both of those into CI. Suggestions on CI are welcome. I'll update this at some point soon with a roadmap for testing/linting.

@cg505 cg505 self-assigned this Jun 6, 2017
@cg505
Copy link
Contributor

cg505 commented Jun 7, 2017

I'm thinking we should use buttercup for tests.

@cg505
Copy link
Contributor

cg505 commented Jun 7, 2017

Linting will be a combo of CEDET's checkdoc and elisp-lint.

@cg505
Copy link
Contributor

cg505 commented Jun 7, 2017

I'm gonna start work on this using these. lmk asap if you have an issue with that. planning on using travis

@rye rye changed the title Clean-Up and Edge Case Handling Testing and CI Jun 27, 2017
@rye rye mentioned this issue Jun 27, 2017
@cg505
Copy link
Contributor

cg505 commented Jul 19, 2017

I edited the initial comment to include a task list.

@rye
Copy link
Member Author

rye commented Jul 19, 2017

I'm not sure about using Coveralls out of necessity. Do you know if CodeClimate supports EmacsLisp?

@cg505
Copy link
Contributor

cg505 commented Jul 19, 2017

I'm pretty sure it doesn't. I already have basic Coveralls support in the coverage-reporting branch. The overhead is pretty minimal. I'm not super satisfied with it at this point, which is why I haven't opened a PR, but at the same time, it's kinda a "why not" thing.

@cg505
Copy link
Contributor

cg505 commented Aug 2, 2017

Are we good with using undercover? Due to the way coverage libraries for emacs lisp are implemented, it will only show coverage for files that are at least a little tested... so the percentages may be off at first. Still should be a useful tool and I already pretty much have it implemented.

@rye
Copy link
Member Author

rye commented Aug 3, 2017

I'm open to whatever you have, so long as it works.

@rye rye added this to the Version 0.2.0 milestone Jul 7, 2018
@rye rye modified the milestones: Version 0.2.0, Version 0.3.0 Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants