From 3583ec50a1dee9a1b483fd6c09c1466d0f875ca8 Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Thu, 9 Jan 2025 17:49:00 +0900 Subject: [PATCH] Fix lint errors --- dev/release/bump_version.sh | 8 ++++---- dev/release/verify_rc.sh | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dev/release/bump_version.sh b/dev/release/bump_version.sh index 6681b115d..d1b164f10 100755 --- a/dev/release/bump_version.sh +++ b/dev/release/bump_version.sh @@ -33,8 +33,8 @@ version=$1 cd "${SOURCE_TOP_DIR}" -git switch -c bump-version-${version} -mvn versions:set -DnewVersion=${version} -DprocessAllModules -DgenerateBackupPoms=false +git switch -c "bump-version-${version}" +mvn versions:set "-DnewVersion=${version}" -DprocessAllModules -DgenerateBackupPoms=false case "${version}" in *-SNAPSHOT) tag=main @@ -43,8 +43,8 @@ case "${version}" in tag=v${version} ;; esac -mvn versions:set-scm-tag -DnewTag=${tag} -DgenerateBackupPoms=false -pl :arrow-java-root -mvn versions:set-scm-tag -DnewTag=${tag} -DgenerateBackupPoms=false -pl :arrow-bom +mvn versions:set-scm-tag "-DnewTag=${tag}" -DgenerateBackupPoms=false -pl :arrow-java-root +mvn versions:set-scm-tag "-DnewTag=${tag}" -DgenerateBackupPoms=false -pl :arrow-bom git add "pom.xml" git add "**/pom.xml" git commit -m "MINOR: Bump version to ${version}" diff --git a/dev/release/verify_rc.sh b/dev/release/verify_rc.sh index f022b622b..c5942552a 100755 --- a/dev/release/verify_rc.sh +++ b/dev/release/verify_rc.sh @@ -124,7 +124,7 @@ ensure_source_directory() { } test_source_distribution() { - if [ ${VERIFY_SOURCE} -le 0 ]; then + if [ "${VERIFY_SOURCE}" -le 0 ]; then return 0 fi @@ -135,7 +135,7 @@ test_source_distribution() { } test_binary_distribution() { - if [ ${VERIFY_SOURCE} -le 0 ]; then + if [ "${VERIFY_BINARY}" -le 0 ]; then return 0 fi