Skip to content

Commit

Permalink
...
Browse files Browse the repository at this point in the history
  • Loading branch information
@kovidgoyal
kovidgoyal committed Jun 28, 2024
1 parent 5e8a945 commit 4804084
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions setup/iso_codes.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ def db_data(self, name: str) -> bytes:
def extract_po_files(self, name: str, output_dir: str) -> None:
name = name.split('.', 1)[0]
pat = f'{self.top_level}/{name}/*.po'
if self.zip_data is None:
self._zip_data = BytesIO(download_securely(self.URL))
with zipfile.ZipFile(self.zip_data) as zf:
for name in fnmatch.filter(zf.namelist(), pat):
dest = os.path.join(output_dir, name.split('/')[-1])
Expand Down

3 comments on commit 4804084

@eli-schwartz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So erm I take it the PR to make building a source code tarball "reproducible" was actually broken all along...

@kovidgoyal
Copy link
Owner Author

@kovidgoyal kovidgoyal commented on 4804084 Jun 28, 2024 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eli-schwartz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It allows them to pretend that statically cp'ed-in-place files are reproducible, which is to say, nothing at all.

My general advice is simply do not accept PRs from NixOS users, because they are sure to be wrong...

Please sign in to comment.