Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small fix #2524

Merged
merged 4 commits into from
Nov 17, 2024
Merged

Various small fix #2524

merged 4 commits into from
Nov 17, 2024

Conversation

un-pogaz
Copy link
Contributor

Three various small fix

  1. Add & operator and $ prefix to their doc function
  2. Remove space in some functions arguments
  3. Fix various unquoted arguments

@kovidgoyal
Copy link
Owner

@cbhaley please review

@cbhaley
Copy link
Contributor

cbhaley commented Nov 17, 2024

These are all good changes with one exception. That exception: in the commit "add & operator and $ prefix doc" the addition in the second hunk, "The $ prefix can be used instead of the function, as in $tags." is incorrect. The function returns the count of items in a multi-valued field. $field returns the field itself.

@un-pogaz
Copy link
Contributor Author

Hum... crap. I miss the good function to that, I push the fix.

@cbhaley
Copy link
Contributor

cbhaley commented Nov 17, 2024

All good now.

@kovidgoyal kovidgoyal merged commit a83d7b0 into kovidgoyal:master Nov 17, 2024
4 checks passed
@un-pogaz un-pogaz deleted the various-small-fix branch November 29, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants