Fix #2333. Remove not none arg parse defaults. #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilovelinux
changed the title
ilovelinux
changed the title
ilovelinux
force-pushed
the
fix/2333-ilovelinux-fix-defaults
branch
from
aee8044 to
81fce3f
Compare
gaborbernat
requested changes
Mar 4, 2025
CodSpeed Performance ReportMerging #2334 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2334 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 65 65
Lines 7792 7798 +6
Branches 775 776 +1
=======================================
+ Hits 7667 7673 +6
Misses 91 91
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Nonearg parse defaults__main__.Config, are the same.Fix #2333
Breaking changes
None