Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/improve printf support #578

Open
4 tasks
kpet opened this issue Jul 16, 2023 · 2 comments
Open
4 tasks

Fix/improve printf support #578

kpet opened this issue Jul 16, 2023 · 2 comments

Comments

@kpet
Copy link
Owner

kpet commented Jul 16, 2023

  • Support batching kernels that use printf
  • Remove serialisation between kernel regions when printf is used
  • Introduce unit test callback to give tests access to printf's output stream and remove all stdout capture logic (Implement printf #565 (comment))
  • Fix concurrent accesses to the printf buffer (Implement printf #565 (comment)). Add tests.
@Rekt3421
Copy link
Contributor

Rekt3421 commented Sep 9, 2024

Hey Kevin can you please check off point 3? I will start working on other parts now.

@rjodinchr
Copy link
Contributor

To fix the issue with concurrent accesses, we mentioned during our last discussion that we might just not perform any reset.
I don't think this would be working because, when we print on clvk side, we go from offset 0, to the end offset.
The issue is with both 0 (the start offset) and the end offset (first word of the printf buffer).

So 2 possibilities:

  • continuing the work that @Rekt3421 started (having one printf buffer per kernel instead of having one per queue)
  • changing the printf interface in clspv to use another buffer containing 2 words (a per-kernel buffer) to indicate the start&end offset

@kpet what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants