Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a declarative way of updating, akin to kubectl apply #443

Open
ion-elgreco opened this issue Jul 9, 2024 · 6 comments
Open

Support a declarative way of updating, akin to kubectl apply #443

ion-elgreco opened this issue Jul 9, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@ion-elgreco
Copy link

Which project are you requesting an enhancement for?

kr8s

What do you need?

I only see create or patch in the methods, but no way to do something like that's akin to kubectl apply

@ion-elgreco ion-elgreco added the enhancement New feature or request label Jul 9, 2024
@ion-elgreco
Copy link
Author

Never mind :D

@ion-elgreco ion-elgreco closed this as not planned Won't fix, can't repro, duplicate, stale Jul 9, 2024
@jacobtomlinson
Copy link
Member

I'm curious why you closed this out? Currently we do not support apply() but I definitely want to add it at some point.

I started an implementation in #75 but it has gone stale and I need to revisit it. There is some complexity around client-side and server-side applies which makes this slightly less trivial than implementing a traditional upsert.

@jacobtomlinson jacobtomlinson changed the title Does kr8s support a declarative way of updating, akin to kubectl apply Support a declarative way of updating, akin to kubectl apply Jul 10, 2024
@ion-elgreco
Copy link
Author

@jacobtomlinson so I was using patch, but I thought I showed the same behaviours as kubectl apply, since it gave an error when I changed a resource in the cluster, but didn't update the python object

@jacobtomlinson
Copy link
Member

Sure it is similar, but the .patch() implementation in kr8s is the same as the kubectl patch implementation. There are some differences between kubectl patch and kubectl apply.

@ion-elgreco
Copy link
Author

@jacobtomlinson is this something you plan on reviving?

@jacobtomlinson
Copy link
Member

It's on the backlog but I haven't gotten to it yet. It's definitely something we should add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants