Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate serde serialization from base code, so that it can be skipped using Cargo features #2

Open
krial057 opened this issue Jul 1, 2020 · 0 comments
Labels
enhancement New feature or request misp_types Issues concerning the misp_types crate

Comments

@krial057
Copy link
Owner

krial057 commented Jul 1, 2020

It would be nice to be able to compile the misp_types crate without serialization features/serde. There is already a json-using-serde feature configured in the Cargo.toml. However, I make use of alot of serde derives which makes it difficult to split the code depending on the feature configurations. Would be nice to create manual serde serializations/deserializations functions instead of using the derives. This way, the serde dependency can easily be added/removed depending on the feature set.

@krial057 krial057 added enhancement New feature or request misp_types Issues concerning the misp_types crate labels Jul 1, 2020
@krial057 krial057 changed the title Separate serde serialization from base code, so that it can be skipped using features Separate serde serialization from base code, so that it can be skipped using Cargo features Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request misp_types Issues concerning the misp_types crate
Projects
None yet
Development

No branches or pull requests

1 participant