Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Klampt PyQt6 Support on Apple Silicon? #171

Open
smeng9 opened this issue Sep 13, 2023 · 1 comment
Open

Klampt PyQt6 Support on Apple Silicon? #171

smeng9 opened this issue Sep 13, 2023 · 1 comment

Comments

@smeng9
Copy link
Contributor

smeng9 commented Sep 13, 2023

Hi Professor,

Most of the Mac series have moved to apple silicon and PyQt5 has extremely bad compatibility. The download package on PyPI https://pypi.org/project/PyQt5/#files only supports x86_64. PyQt5 is also considered to be superseded by PyQt6.

The GLUT on Mac also has Fatal Error: internal error: NSInternalInconsistencyException, reason: NSWindow drag regions should only be invalidated on the Main Thread! when freshly installed with klampt. So as for now, none of the visualization can work on latest Mac.

I have perform a search of the string PyQt5 in the codebase and found there are not too many of them. The visualization libraries are modularized very well so we can simply do replaces of them using PyQt6. We could also remove PyQt4 that have already reached its end of life.

I can start with some effort for early adoption usage of PyQt6. What is your thought on this?

Thanks for creating this awesome library.

@krishauser
Copy link
Owner

That’s a good change to pursue. It should be relatively simple to bump the code that checks for PyQt5 to 6 and the fallback code from PyQt4 to 5. However I haven’t looked carefully at how 6 could break existing code. If you could try this and submit a PR, I’d appreciate it! We are trying to update Klampt to support newer macs, but few of us on the team use macs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants