-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathagent_test.go
427 lines (350 loc) · 13.3 KB
/
agent_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
package sshx
import (
"crypto/rand"
"crypto/rsa"
"io"
"net"
"os"
"path/filepath"
"testing"
"time"
gocmp "github.com/google/go-cmp/cmp"
"github.com/stretchr/testify/mock"
"golang.org/x/crypto/ssh"
"golang.org/x/crypto/ssh/agent"
"gotest.tools/v3/assert"
"gotest.tools/v3/assert/cmp"
)
func Test_NewAgent(t *testing.T) {
t.Run("ok", func(t *testing.T) {
agentSocketPath := filepath.Join(t.TempDir(), "agent.sock")
t.Setenv(_sshAuthSockFileEnv, agentSocketPath)
listener, listenerErr := net.Listen("unix", agentSocketPath)
assert.NilError(t, listenerErr)
doneListening := make(chan struct{})
go func() {
t.Cleanup(func() { assert.NilError(t, listener.Close()) })
agentConn, err := listener.Accept()
assert.NilError(t, err)
t.Cleanup(func() { assert.NilError(t, agentConn.Close()) })
close(doneListening)
}()
sshAgent, closeSSHAgent, err := NewAgent()
assert.NilError(t, err)
assert.Assert(t, sshAgent != nil)
assert.Assert(t, closeSSHAgent != nil)
assert.NilError(t, closeSSHAgent())
<-doneListening
})
t.Run("ko", func(t *testing.T) {
t.Run("env var is unset", func(t *testing.T) {
assert.NilError(t, os.Unsetenv(_sshAuthSockFileEnv))
sshAgent, closeSSHAgent, err := NewAgent()
assert.Assert(t, cmp.ErrorContains(err, "undefined agent unix socket env"))
assert.Check(t, cmp.Nil(sshAgent))
assert.Check(t, cmp.Nil(closeSSHAgent))
})
t.Run("env var is unset", func(t *testing.T) {
agentSocketPath := filepath.Join(t.TempDir(), "agent.sock")
t.Setenv(_sshAuthSockFileEnv, agentSocketPath)
sshAgent, closeSSHAgent, err := NewAgent()
assert.Assert(t, cmp.ErrorContains(err, "unable to connect to the agent"))
assert.Check(t, cmp.Nil(sshAgent))
assert.Check(t, cmp.Nil(closeSSHAgent))
})
})
}
func Test_Agent_UpsertKey(t *testing.T) {
rsaPrivKey1, err := rsa.GenerateKey(rand.Reader, 2048)
assert.NilError(t, err)
rsaPrivKey2, err := rsa.GenerateKey(rand.Reader, 2048)
assert.NilError(t, err)
privKey1, err := WrapPrivateKey(rsaPrivKey1)
assert.NilError(t, err)
privKey2, err := WrapPrivateKey(rsaPrivKey2)
assert.NilError(t, err)
newAgentMock := func(t *testing.T) *agentMock {
agentMock := new(agentMock)
agentMock.Test(t)
t.Cleanup(func() { agentMock.AssertExpectations(t) })
return agentMock
}
t.Run("ok", func(t *testing.T) {
agentMock := newAgentMock(t)
sshAgent := Agent{Agent: agentMock}
{ // the agent already contain the second private key
agentMock.On("List").Return([]*agent.Key{
{Format: "rsa", Blob: privKey2.PublicKey().Marshal()},
}, nil).Once()
agentMock.On("Add", agent.AddedKey{PrivateKey: rsaPrivKey1}).Return(nil).Once()
}
assert.Check(t, sshAgent.UpsertKey(privKey1))
{ // the agent now contain the two private keys
agentMock.On("List").Return([]*agent.Key{
{Format: "rsa", Blob: privKey2.PublicKey().Marshal()},
{Format: "rsa", Blob: privKey1.PublicKey().Marshal()},
}, nil).Once()
agentMock.On("Remove", &agent.Key{Format: "rsa", Blob: privKey2.PublicKey().Marshal()}).Return(nil).Once()
agentMock.On("Add", agent.AddedKey{PrivateKey: rsaPrivKey2}).Return(nil).Once()
}
assert.Check(t, sshAgent.UpsertKey(privKey2))
{ // the agent now contain the two private keys
agentMock.On("List").Return([]*agent.Key{
{Format: "rsa", Blob: privKey2.PublicKey().Marshal()},
{Format: "rsa", Blob: privKey1.PublicKey().Marshal()},
}, nil).Once()
agentMock.On("Remove", &agent.Key{Format: "rsa", Blob: privKey1.PublicKey().Marshal()}).Return(nil).Once()
agentMock.On("Add", agent.AddedKey{PrivateKey: rsaPrivKey1}).Return(nil).Once()
}
assert.Check(t, sshAgent.UpsertKey(privKey1))
})
t.Run("ko", func(t *testing.T) {
t.Run("unable to remove", func(t *testing.T) {
agentMock := newAgentMock(t)
agentMock.On("List").Return(nil, errForTest).Once()
sshAgent := Agent{Agent: agentMock}
err := sshAgent.UpsertKey(privKey1)
assert.Assert(t, cmp.ErrorContains(err, "unable to remove existing private key from agent"))
assert.Check(t, cmp.Contains(err.Error(), errForTest.Error()))
})
t.Run("unable to add", func(t *testing.T) {
agentMock := newAgentMock(t)
agentMock.On("List").Return(nil, nil).Once()
agentMock.On("Add", mock.Anything).Return(errForTest).Once()
sshAgent := Agent{Agent: agentMock}
err := sshAgent.UpsertKey(privKey1)
assert.Assert(t, cmp.ErrorContains(err, "unable to add private key to agent"))
assert.Check(t, cmp.Contains(err.Error(), errForTest.Error()))
})
})
}
func Test_Agent_UpsertCertificate(t *testing.T) {
now := time.Now()
rsaPrivKey, err := rsa.GenerateKey(rand.Reader, 2048)
assert.NilError(t, err)
privKey, err := WrapPrivateKey(rsaPrivKey)
assert.NilError(t, err)
t.Run("ok", func(t *testing.T) {
t.Run("without constraints", func(t *testing.T) {
sshCert := newTestSSHCertificate(t, privKey, privKey.Signer())
cert := (*Certificate)(sshCert)
agentMock := newAgentMock(t)
agentMock.On("List").Return(nil, nil).Once()
agentMock.On("Add", agent.AddedKey{PrivateKey: rsaPrivKey}).Return(nil).Once()
agentMock.On("Add", agent.AddedKey{
PrivateKey: rsaPrivKey,
Certificate: sshCert,
}).Return(nil).Once()
sshAgent := Agent{Agent: agentMock}
assert.Check(t, sshAgent.UpsertCertificate(privKey, *cert))
})
t.Run("with constraints", func(t *testing.T) {
sshCert := newTestSSHCertificate(t, privKey, privKey.Signer(), func(cert *ssh.Certificate) {
cert.ValidAfter = uint64(now.Add(-time.Minute).Unix())
cert.ValidBefore = uint64(now.Add(time.Minute).Unix())
})
cert := (Certificate)(*sshCert)
agentMock := newAgentMock(t)
agentMock.On("List").Return(nil, nil).Once()
agentMock.On("Add", agent.AddedKey{PrivateKey: rsaPrivKey}).Return(nil).Once()
agentMock.On("Add", mock.MatchedBy(func(key agent.AddedKey) bool {
match := agent.AddedKey{PrivateKey: rsaPrivKey, Certificate: sshCert, LifetimeSecs: uint32(time.Minute.Seconds())}
return cmp.DeepEqual(match, key,
gocmp.FilterPath(
func(path gocmp.Path) bool { return path.String() == "Certificate" },
gocmp.Comparer(func(x, y *ssh.Certificate) bool {
return cmpCertificate((*Certificate)(x), (*Certificate)(y))().Success()
}),
),
gocmp.FilterPath(
func(path gocmp.Path) bool { return path.String() == "LifetimeSecs" },
gocmp.Comparer(func(x, y uint32) bool { return x-y < 3 }),
),
)().Success()
})).Return(nil).Once()
sshAgent := Agent{Agent: agentMock}
assert.NilError(t, sshAgent.UpsertCertificate(privKey, cert))
})
})
t.Run("ko", func(t *testing.T) {
t.Run("invalid cert", func(t *testing.T) {
sshCert := newTestSSHCertificate(t, privKey, privKey.Signer(), func(cert *ssh.Certificate) {
cert.ValidAfter = uint64(time.Now().Add(time.Hour).Unix())
})
cert := (Certificate)(*sshCert)
sshAgent := Agent{Agent: newAgentMock(t)}
err := sshAgent.UpsertCertificate(privKey, cert)
assert.ErrorContains(t, err, "invalid certificate")
})
t.Run("unable to upsert key", func(t *testing.T) {
sshCert := newTestSSHCertificate(t, privKey, privKey.Signer())
cert := (Certificate)(*sshCert)
agentMock := newAgentMock(t)
agentMock.On("List").Return(nil, errForTest).Once()
sshAgent := Agent{Agent: agentMock}
err := sshAgent.UpsertCertificate(privKey, cert)
assert.ErrorContains(t, err, "unable to upsert private key")
})
t.Run("unable to add key", func(t *testing.T) {
sshCert := newTestSSHCertificate(t, privKey, privKey.Signer())
cert := (Certificate)(*sshCert)
agentMock := newAgentMock(t)
agentMock.On("List").Return(nil, nil).Once()
agentMock.On("Add", agent.AddedKey{PrivateKey: rsaPrivKey}).Return(nil).Once()
agentMock.On("Add", mock.Anything).Return(errForTest).Once()
sshAgent := Agent{Agent: agentMock}
err := sshAgent.UpsertCertificate(privKey, cert)
assert.ErrorContains(t, err, "unable to add certificate to agent")
})
})
}
func Test_Agent_GetSignerMatchingPublicKey(t *testing.T) {
privKey1 := newTestPrivateKey(t)
privKey2 := newTestPrivateKey(t)
t.Run("ok", func(t *testing.T) {
signerMock1 := newSignerMock(t)
signerMock1.On("PublicKey").Return(privKey1.PublicKey()).Once()
signerMock2 := newSignerMock(t)
signerMock2.On("PublicKey").Return(privKey2.PublicKey()).Once()
agentMock := newAgentMock(t)
agentMock.On("Signers").Return([]ssh.Signer{signerMock2, signerMock1}, nil).Once()
sshAgent := Agent{Agent: agentMock}
signer, err := sshAgent.GetSignerMatchingPublicKey(privKey1.PublicKey())
assert.NilError(t, err)
assert.Equal(t, signer, signerMock1)
})
t.Run("ko", func(t *testing.T) {
t.Run("unable to get signers", func(t *testing.T) {
agentMock := newAgentMock(t)
agentMock.On("Signers").Return(nil, errForTest).Once()
sshAgent := Agent{Agent: agentMock}
signer, err := sshAgent.GetSignerMatchingPublicKey(privKey1.PublicKey())
assert.Assert(t, cmp.ErrorContains(err, "unable to get signers in agent"))
assert.Check(t, cmp.Contains(err.Error(), errForTest.Error()))
assert.Check(t, cmp.Nil(signer))
})
t.Run("no matching signers", func(t *testing.T) {
signerMock1 := newSignerMock(t)
signerMock1.On("PublicKey").Return(privKey2.PublicKey()).Once()
signerMock2 := newSignerMock(t)
signerMock2.On("PublicKey").Return(privKey2.PublicKey()).Once()
agentMock := newAgentMock(t)
agentMock.On("Signers").Return([]ssh.Signer{signerMock2, signerMock1}, nil).Once()
sshAgent := Agent{Agent: agentMock}
signer, err := sshAgent.GetSignerMatchingPublicKey(privKey1.PublicKey())
assert.ErrorIs(t, err, ErrSignerNotFound)
assert.Check(t, cmp.Nil(signer))
})
})
}
func Test_Agent_RemoveMatchingPublicKey(t *testing.T) {
privKey1 := newTestPrivateKey(t)
privKey2 := newTestPrivateKey(t)
t.Run("ok", func(t *testing.T) {
t.Run("nothing in the agent", func(t *testing.T) {
agentMock := newAgentMock(t)
agentMock.On("List").Return(nil, nil).Once()
sshAgent := Agent{Agent: agentMock}
assert.NilError(t, sshAgent.RemoveMatchingPublicKey(privKey1.PublicKey()))
})
t.Run("key found in the agent", func(t *testing.T) {
agentMock := newAgentMock(t)
agentMock.On("List").Return([]*agent.Key{
{Format: "rsa", Blob: privKey2.PublicKey().Marshal()},
{Format: "rsa", Blob: privKey1.PublicKey().Marshal()},
{Format: "rsa", Blob: privKey2.PublicKey().Marshal()},
}, nil).Once()
agentMock.On("Remove", &agent.Key{Format: "rsa", Blob: privKey2.PublicKey().Marshal()}).Return(nil).Twice()
sshAgent := Agent{Agent: agentMock}
assert.NilError(t, sshAgent.RemoveMatchingPublicKey(privKey2.PublicKey()))
})
})
t.Run("ko", func(t *testing.T) {
t.Run("unable to list", func(t *testing.T) {
agentMock := newAgentMock(t)
agentMock.On("List").Return(nil, errForTest).Once()
sshAgent := Agent{Agent: agentMock}
err := sshAgent.RemoveMatchingPublicKey(privKey1.PublicKey())
assert.Assert(t, cmp.ErrorContains(err, "unable to list keys in agent"))
assert.Check(t, cmp.Contains(err.Error(), errForTest.Error()))
})
t.Run("unable to remove", func(t *testing.T) {
agentMock := newAgentMock(t)
agentMock.On("List").Return([]*agent.Key{{Format: "rsa", Blob: privKey1.PublicKey().Marshal()}}, nil).Once()
agentMock.On("Remove", mock.Anything).Return(errForTest).Once()
sshAgent := Agent{Agent: agentMock}
err := sshAgent.RemoveMatchingPublicKey(privKey1.PublicKey())
assert.Assert(t, cmp.ErrorContains(err, "unable to remove key from agent"))
assert.Check(t, cmp.Contains(err.Error(), errForTest.Error()))
})
})
}
type agentMock struct{ mock.Mock }
func newAgentMock(t *testing.T) *agentMock {
agentMock := new(agentMock)
agentMock.Test(t)
t.Cleanup(func() { agentMock.AssertExpectations(t) })
return agentMock
}
func (m *agentMock) List() ([]*agent.Key, error) {
args := m.Called()
var keys []*agent.Key
if arg := args.Get(0); arg != nil {
keys = arg.([]*agent.Key)
}
return keys, args.Error(1)
}
func (m *agentMock) Sign(key ssh.PublicKey, data []byte) (*ssh.Signature, error) {
args := m.Called(key, data)
var signature *ssh.Signature
if arg := args.Get(0); arg != nil {
signature = arg.(*ssh.Signature)
}
return signature, args.Error(1)
}
func (m *agentMock) Add(key agent.AddedKey) error {
return m.Called(key).Error(0)
}
func (m *agentMock) Remove(key ssh.PublicKey) error {
return m.Called(key).Error(0)
}
func (m *agentMock) RemoveAll() error {
return m.Called().Error(0)
}
func (m *agentMock) Lock(passphrase []byte) error {
return m.Called(passphrase).Error(0)
}
func (m *agentMock) Unlock(passphrase []byte) error {
return m.Called(passphrase).Error(0)
}
func (m *agentMock) Signers() ([]ssh.Signer, error) {
args := m.Called()
var signers []ssh.Signer
if arg := args.Get(0); arg != nil {
signers = arg.([]ssh.Signer)
}
return signers, args.Error(1)
}
type signerMock struct{ mock.Mock }
func newSignerMock(t *testing.T) *signerMock {
signerMock := new(signerMock)
signerMock.Test(t)
t.Cleanup(func() { signerMock.AssertExpectations(t) })
return signerMock
}
func (m *signerMock) PublicKey() ssh.PublicKey {
args := m.Called()
var pubKey ssh.PublicKey
if arg := args.Get(0); arg != nil {
pubKey = arg.(ssh.PublicKey)
}
return pubKey
}
func (m *signerMock) Sign(randomReader io.Reader, data []byte) (*ssh.Signature, error) {
args := m.Called(randomReader, data)
var signature *ssh.Signature
if arg := args.Get(0); arg != nil {
signature = arg.(*ssh.Signature)
}
return signature, args.Error(1)
}