Skip to content
This repository has been archived by the owner on Mar 25, 2020. It is now read-only.

Adding hyperlinks to components #161

Open
dakotabenjamin opened this issue May 10, 2019 · 1 comment
Open

Adding hyperlinks to components #161

dakotabenjamin opened this issue May 10, 2019 · 1 comment

Comments

@dakotabenjamin
Copy link

Hi, I'm trying to contribute this feature but having some trouble:
https://github.com/dakotabenjamin/LambStatus/tree/add/hyperlinks-in-components

One issue I am having is that once created I cannot edit the URL. In the Component Dialog I change the text then hit edit, but when I open the dialog again the text is the old text.

Am I missing something?

@ks888
Copy link
Owner

ks888 commented May 13, 2019

Thank you for your contribution!

When the component is updated, updateComponent action is called instead of postComponent.
https://github.com/dakotabenjamin/LambStatus/blob/9e1690c426c8bb44c56cefd8821f91152e5824da/packages/frontend/src/actions/components.js#L67

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants