Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement editing model servers #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implement editing model servers #16

wants to merge 3 commits into from
+294 −2

Conversation

markwinter
Copy link
Member

@markwinter markwinter commented Nov 3, 2021 •
edited
Loading

Currently it is not possible to edit existing model servers from the web app.

This PR adds a new edit function that lets the users change the existing YAML.
It uses the k8s replace_namespaced_custom_object in the backend.

This will resolve #2 because the user can add the canaryTrafficPercent and change the storageUri

@kimwnasptd Can you review this please?

image

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markwinter
To complete the pull request process, please assign kimwnasptd after the PR has been reviewed.
You can assign the PR to them by writing /assign @kimwnasptd in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markwinter
Copy link
Member Author

/retest

@juliusvonkohout
Copy link
Contributor

@markwinter Please rebase to master

@oss-prow-bot OSS-prow-bot
Copy link

oss-prow-bot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markwinter
Once this PR has been reviewed and has the lgtm label, please assign juliusvonkohout for approval by writing /assign @juliusvonkohout in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Contributor

Alright then you have to fix the broken tests.

@juliusvonkohout
Copy link
Contributor

Can you rebase to master and fix the tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Canary Rollout From KF-Serving Web App UI
3 participants
@markwinter @kserve-oss-bot @juliusvonkohout