[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: disrupted
To complete the pull request process, please assign kimwnasptd after the PR has been reviewed.
You can assign the PR to them by writing /assign @kimwnasptd in a comment when ready.

The full list of commands accepted by this bot can be found here.

hi @disrupted,

when I deployed the paddle inferecenservice with KServe, the kubeflow models-web-app had the display problem and had the error as following figure,

I think there is not the paddle servingruntime, and return None to cause the error. When I add the 'paddle' PredictType, patch and rebuild the models-web-app image, the problem can be fixed and the display become correctly, there is my changes,

https://github.com/harperjuanl/models-web-app

I also test your method, it does work too. I see it returns the predictor.model and remove the judgement. Does it have the problem that some frameworks are returned, which do not be supported by KServe?

hi @harperjuanl,

thanks for your feedback, as well as verifying the issue & potential fix. Perhaps you're right, that this could lead to some issues with other frameworks, however I thought that ServingRuntimes are always specific to KServe and not used in other scenarios.

Adding custom ServingRuntimes (such as paddle in your case) to the known list of predictor types seems like a reasonable approach as well. But this would be better if it could be done through the KServe configuration, rather than having to patch the code, as it is the case in your example.

@disrupted Please rebase to master

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: disrupted
Once this PR has been reviewed and has the lgtm label, please assign juliusvonkohout for approval by writing /assign @juliusvonkohout in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

@disrupted Please rebase to master

done

@disrupted you also have to sign the DCO to pass all tests.

@disrupted you also have to sign the DCO to pass all tests.

done

/assign @juliusvonkohout

@disrupted the frontend test is not passing. Maybe it is broken.

@disrupted the frontend test is not passing. Maybe it is broken.

it appears to me that the error is unrelated to the changes made in this PR

@disrupted the frontend test is not passing. Maybe it is broken.

it appears to me that the error is unrelated to the changes made in this PR

You might be right, but we still have to fix the tests either way.

merged in #92