From 5af845eb0cc240bd310f93e6ebdd9ea604a52e15 Mon Sep 17 00:00:00 2001 From: Kimonas Sotirchos Date: Tue, 1 Mar 2022 18:55:55 +0200 Subject: [PATCH 1/2] manifests: Use explicit gateways Replace the variable substitution for the web app and hardcode the Gateway that will be used in each case. Signed-off-by: Kimonas Sotirchos --- config/base/istio.yaml | 2 +- config/overlays/kubeflow/patches/web-app-vsvc.yaml | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/config/base/istio.yaml b/config/base/istio.yaml index dcd3211..944eddb 100644 --- a/config/base/istio.yaml +++ b/config/base/istio.yaml @@ -5,7 +5,7 @@ metadata: namespace: kserve spec: gateways: - - $(ingressGateway) + - knative-serving/knative-ingress-gateway hosts: - '*' http: diff --git a/config/overlays/kubeflow/patches/web-app-vsvc.yaml b/config/overlays/kubeflow/patches/web-app-vsvc.yaml index f35fed0..979f661 100644 --- a/config/overlays/kubeflow/patches/web-app-vsvc.yaml +++ b/config/overlays/kubeflow/patches/web-app-vsvc.yaml @@ -1,3 +1,7 @@ +- op: replace + path: /spec/gateways + value: + - kubeflow/kubeflow-gateway - op: replace path: /spec/http/0/route/0/destination value: From 4ed3594e85b7472a7155ea013b8472a668a979a3 Mon Sep 17 00:00:00 2001 From: Kimonas Sotirchos Date: Tue, 1 Mar 2022 18:56:54 +0200 Subject: [PATCH 2/2] manifests: Set the prefix in the backend The backend should also be aware of the prefix in order to configure the frontend files accordingly. Signed-off-by: Kimonas Sotirchos --- config/overlays/kubeflow/kustomization.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/config/overlays/kubeflow/kustomization.yaml b/config/overlays/kubeflow/kustomization.yaml index 985eb83..18f0724 100644 --- a/config/overlays/kubeflow/kustomization.yaml +++ b/config/overlays/kubeflow/kustomization.yaml @@ -36,6 +36,7 @@ configMapGenerator: behavior: replace literals: - USERID_HEADER=kubeflow-userid + - APP_PREFIX=/kserve-endpoints configurations: - params.yaml