Discipline functions members of nested types

[TristanJamesBall]

I'm not sure if I'm doing something wrong here, but I can't seem to trigger the 'get' discipline on the i member an Inner_t variable when that variable is defined inside another type - but it works fine when the variable is stand alone?

Happy to log a bug for this of course, just wanted to make sure I'm not doing something goofy first?

typeset -T Inner_t=(
    _=(v='in')
    integer i=4
    get() {
        .sh.value="Inner.get ${_._.v}"
    }

    i.get() {
        .sh.value="Inner.i.get ${!_} $_"
    }

)

typeset -T Outer_t=(
    _=(v='out')
    Inner_t in
    integer o=2
    get() {
        .sh.value="Outer.get ${_._.v}"
    }
    o.get() {
     #   nameref s=$_
        .sh.value="Outer.o.get ${!_} $_"
    }
)

Outer_t o
Inner_t i

print $o
print ${o.o}
print ${o.in}
print ${o.in.i}
print '---'
print ${i.i}

Output:

Outer.get out
Outer.o.get o.o 2
Inner.get in
4
---
Inner.i.get i.i 4

I'd be expecting

Outer.get out
Outer.o.get o.o 2
Inner.get in
Inner.i.get i.i 4
---
Inner.i.get i.i 4

[rwmills]

I don't know what version you are running but I am on Ksh 93u+m/1.0.0-beta.2 2021-12-17 and I get a different result to you. Have you posted the correct results?

Now as to your question about not being able to 'trigger' the Inner_t get. From my understanding on how user defined types work, your definition of the Outer_t get has replaced the Inner_t get. If you give the functions meaningful/unique names (you are not limited to the discipline names) then all should be ok. See the 2 examples below.

$ ./tjb              
Outer.get out
Outer.o.get o.o 
Inner.get in
4
---
Inner.i.get i.i 
$

Example 1

#! /usr/bin/ksh93

typeset -T Point_t=(
  integer -h 'x coordinate' x=0
  integer -h 'y coordinate' y=0
  typeset -h 'point colour' colour="red"

  function getcolour {
    print -r ${_.colour}
    }

  function setcolour {
    _.colour=$1
    }

  setxy() {
    _.x=$1; _.y=$2
    }

  getxy() {
    print -r "(${_.x},${_.y})"
    }
  )

  Point_t point

  echo "Initial coordinates are (${point.x},${point.y}). colour is ${point.colour}"

  point.setxy 5 6
  point.setcolour blue

  echo "New coordinates are ${point.getxy}. colour is ${point.getcolour}"

  exit 0

Example 2

#! /usr/bin/ksh93

typeset -T Object_t=(
  integer -S -h 'number of objects' count=0

  create() {
    (( _.count--))
    }
  )

typeset -T Colour_t=(
  Object_t _
  typeset -h 'fill colour' fill="blue"

  function getcolour {
    print -r ${_.fill}
    }

  function setcolour {
    _.fill=$1
    }
  )

typeset -T Shape_t=(
  Colour_t _
  integer -h 'offset x'    offsetx=0
  integer -h 'offset y'    offsety=0
  float   -h 'dimension a' a=0
  )

typeset -T Circle_t=(
  Shape_t _

  create() {
    (( _.count++))
    }

  area() {
    print -r $(( 3.14 *_.a *_.a))
    }

  circumference() {
    print -r $(( 6.28 * _.a))
    }
  )

typeset -T Rectangle_t=(
  Shape_t _
  float -h 'dimension b' b=0

  create() {
    (( _.count++))
    }

  area() {
    print -r $((_.a *_.b))
    }

  perimeter() {
    print -r $(( 2 * (_.a + _.b)))
    }
  )

typeset -T Triangle_t=(
  Rectangle_t _
  float -h 'dimension c' c=0

  create() {
    (( _.count++))
    }

  area() {
    print -r $(( _.a * _.b / 2))
    }

  perimeter() {
    print -r $(( _.a + _.b + _.c))
    }
  )

echo "Creating rectangle1 with default fill and offsets ...."
Rectangle_t rectangle1=(a=2 b=4)

echo "Area of rectangle1 is: ${rectangle1.area}"
echo "Perimeter of rectangle1 is: ${rectangle1.perimeter}"
echo "Colour of rectangle1 is: ${rectangle1.fill}"
echo "Co-ordinates of rectangle1 are: (${rectangle1.offsetx}, ${rectangle1.offsety})"
echo "Rectangle1 is of type: ${@rectangle1}"
echo "Number of objects created so far : ${.sh.type.Object_t.count}"
echo

echo "Creating circle1 with red fill and offset of (5,10) ...."
Circle_t circle1=(a=2 offsetx=5 offsety=10)
circle1.fill="red"
echo "Area of circle1 is: ${circle1.area}"
echo "Circumference of circle1 is: ${circle1.circumference}"
echo "Colour of circle1 is: ${circle1.fill}"
echo "Co-ordinates of circle1 are: (${circle1.offsetx}, ${circle1.offsety})"
echo

echo "Changing circle1 fill colour to green ...."
circle1.setcolour green
echo "Colour of circle1 is: ${circle1.getcolour}"
echo "Circle1 is of type: ${@circle1}"
echo "Number of objects created so far: ${.sh.type.Object_t.count}"
echo

echo "Creating triangle1 with offset of (12,12) ...."
Triangle_t triangle1=(offsetx=12 offsety=12 a=3 b=4 c=5)
echo "Area of triangle1 is: ${triangle1.area}"
echo "Perimeter of triangle1 is: ${triangle1.perimeter}"
echo "Colour of triangle1 is: ${triangle1.fill}"
echo "Co-ordinates of triangle1 are: (${triangle1.offsetx}, ${triangle1.offsety})"
echo "Triangle1 is of type: ${@triangle1}"
echo "Number of objects created so far: ${.sh.type.Object_t.count}"
echo

echo "Creating triangle2 and triangle3 and comparing them ...."
Triangle_t triangle2=(a=6 b=3 c=5)
Triangle_t triangle3=(a=6 b=3 c=5)
if [[ "$triangle2" == "$triangle3" ]]; then
  echo "CORRECT: triangle2 and triangle3 match"
else
  echo "ERROR: triangle2 and triangle3 do not match"
  fi
echo

echo "Creating triangle4 by assignment from triangle3 and comparing them ...."
Triangle_t triangle4=triangle3
if [[ "$triangle4" == "$triangle3" ]]; then
  echo "CORRECT: triangle4 and triangle3 match"
else
  echo "ERROR: triangle4 and triangle3 do not match"
  fi
echo

echo "Changing colour of triangle4 and comparing them again ...."
triangle4.fill="green"
if [[ "$triangle4" != "$triangle3" ]]; then
  echo "CORRECT: triangle4 and triangle3 differ"
else
  echo "ERROR: triangle4 and triangle3 do not differ"
  fi

exit 0

[rwmills]

@TristanJamesBall; I've just updated to 93u+m/1.0.8 2024-01-01 and am getting the same results that you are. I made several changes to your example but without rewriting it was unable to get the results you were looking for. My only suggestion is for you to have another think about what you want to achieve and rewrite it using the KISS principle and the examples I sent you for ideas. Sorry that I can't offer another solution to you.