From 5ee4098581dbac30c31d9a76e9dd38861684053f Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+ktf@users.noreply.github.com> Date: Tue, 9 Jan 2024 11:24:22 +0100 Subject: [PATCH 1/2] DPL: get rid of warning --- Framework/Core/src/FairMQDeviceProxy.cxx | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Framework/Core/src/FairMQDeviceProxy.cxx b/Framework/Core/src/FairMQDeviceProxy.cxx index a83057e9578be..06a404360d741 100644 --- a/Framework/Core/src/FairMQDeviceProxy.cxx +++ b/Framework/Core/src/FairMQDeviceProxy.cxx @@ -320,10 +320,7 @@ void FairMQDeviceProxy::bind(std::vector const& outputs, std::vecto mInputRoutes.emplace_back(RouteState{channelIndex, false}); ri++; } - for (auto& route : mInputRoutes) { - assert(route.channel.value != -1); - assert(route.channel.value < mInputChannels.size()); - } + assert(std::all_of(mInputRoutes.begin(), mInputRoutes.end(), [s=mInputChannels.size()](InputRoute const&route) {return route.channel.value != -1 && route.channel.value < s;})); LOGP(detail, "Total input channels found {}, total routes {}", mInputChannels.size(), mInputRoutes.size()); assert(mInputRoutes.size() == inputs.size()); } From 59064edb2db92b344ccd9cee3d10ce50a099947f Mon Sep 17 00:00:00 2001 From: ALICE Action Bot Date: Tue, 9 Jan 2024 11:29:05 +0000 Subject: [PATCH 2/2] Please consider the following formatting changes --- Framework/Core/src/FairMQDeviceProxy.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Framework/Core/src/FairMQDeviceProxy.cxx b/Framework/Core/src/FairMQDeviceProxy.cxx index 06a404360d741..76c5ecccde434 100644 --- a/Framework/Core/src/FairMQDeviceProxy.cxx +++ b/Framework/Core/src/FairMQDeviceProxy.cxx @@ -320,7 +320,7 @@ void FairMQDeviceProxy::bind(std::vector const& outputs, std::vecto mInputRoutes.emplace_back(RouteState{channelIndex, false}); ri++; } - assert(std::all_of(mInputRoutes.begin(), mInputRoutes.end(), [s=mInputChannels.size()](InputRoute const&route) {return route.channel.value != -1 && route.channel.value < s;})); + assert(std::all_of(mInputRoutes.begin(), mInputRoutes.end(), [s = mInputChannels.size()](InputRoute const& route) { return route.channel.value != -1 && route.channel.value < s; })); LOGP(detail, "Total input channels found {}, total routes {}", mInputChannels.size(), mInputRoutes.size()); assert(mInputRoutes.size() == inputs.size()); }