New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wk_meta_t geometry_type is recorded as u32 but should be enum wk_geometry_type_enum #10

Open

JosiahParry opened this issue Jul 5, 2023 · 0 comments

Collaborator

JosiahParry commented Jul 5, 2023

The wk_meta_t struct requires a geometry type:

wk-rs/src/bindings_wk.rs

Line 6 in b5ec8fa

pub geometry_type: u32,

However, the enum wk_geometry_type_enum should be used here as it tracks the geometry type. I think in C the enum is parsed as the int.

wk-rs/src/bindings_wk.rs

Line 149 in b5ec8fa

pub enum wk_geometery_type_enum {

Note the way that WK_POINT is used:

https://github.com/paleolimbot/wk/blob/e3d4efbf8e3da559dfe1b202ba5374822273e40f/src/vertex-filter.c#L112C4-L112C4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment