Why make ConfigLoader.load as async ?

[shenshouer]

I noticed that the load method in the ConfigLoader struct does not use await, so why is the load method marked as async?
https://github.com/kube-rs/kube/blob/main/kube-client/src/config/file_loader.rs#L56

[shenshouer]

I am very confused about this. Can someone answer this question?

[clux]

possibly an oversight the way load and read is split. certainly the loading is not doing any io at the moment at least, so the loading could be changed. howevere there's another discussion in #1336 on whether we should make the file reading async, since that's also erroneously not marked async (and uses sync apis - hiding the fact that it is doing io and blocking), but we forgot about it. i'll raise an issue in a bit to consolidate this.

EDIT: issue in Issue now created in #1651

[shenshouer]

I have submitted a PR #1650 to change the load method to sync. Please help check if it meets the requirements.