Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option names for karmor #66

Open
1 of 4 tasks
nyrahul opened this issue Apr 27, 2022 · 0 comments · May be fixed by #76
Open
1 of 4 tasks

option names for karmor #66

nyrahul opened this issue Apr 27, 2022 · 0 comments · May be fixed by #76
Assignees
@s1ntaxe770r

Comments

@nyrahul
Copy link
Contributor

nyrahul commented Apr 27, 2022 •
edited by Ankurk99
Loading

karmor supports similar options in multiple commands, however the option names are different for different commands.

  • option for system|network, cilium|kubearmor ... currently karmor discover uses --policy cilium|kubearmor while karmor insight uses --source system|network ... Ideally we should have similar option name across these commands such as --class application | network
  • in karmor insight the option supported is --rule string ... However, there is no example for how to use this option.
  • better to use --grpc in place of --gRPC
  • karmor insight uses --type field to specify ingress/egress rule filtering. This should be called --ruletype. Btw, --rule and --type seems overlapping.
❯ karmor discover --help
Discover applicable policies

Usage:
  karmor discover [flags]

Flags:
  -c, --clustername string   Filter by Clustername
  -f, --format string        Format: json or yaml (default "json")
  -s, --fromsource string    Filter by policy FromSource
      --gRPC string          gRPC server information
  -h, --help                 help for discover
  -l, --labels string        Filter by policy Label
  -n, --namespace string     Filter by Namespace
  -p, --policy string        Type of policies to be discovered: cilium or kubearmor (default "kubearmor")
❯ karmor insight --help
Policy insight from discovery engine

Usage:
  karmor insight [flags]

Flags:
      --clustername string     Filter according to the Cluster name
      --containername string   Filter according to the Container name
      --fromsource string      Filter according to the source path
      --gRPC string            gRPC server information
  -h, --help                   help for insight
      --labels string          Labels for resources
  -n, --namespace string       Namespace for resources
      --rule string            NW packet Rule
      --source string          The DB for insight : system|network|all (default "all")
      --type string            NW packet type : ingress|egress
@nyrahul nyrahul changed the title option names fors karmor option names for karmor Apr 28, 2022
@s1ntaxe770r s1ntaxe770r self-assigned this May 26, 2022
@s1ntaxe770r s1ntaxe770r linked a pull request May 27, 2022 that will close this issue
Open
@s1ntaxe770r s1ntaxe770r linked a pull request Jun 2, 2022 that will close this issue
option names for karmor #76
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1ntaxe770r s1ntaxe770r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

option names for karmor s1ntaxe770r/kubearmor-client
2 participants
@nyrahul @s1ntaxe770r