Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect preloading process of the Hard Example Mining module. #141

Closed
wants to merge 1 commit into from
Closed

Fix incorrect preloading process of the Hard Example Mining module. #141

wants to merge 1 commit into from

Conversation

FuryMartin
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:

In current Ianvs implementation, the Hard Example Mining(HEM) Module will be loaded as a instance by core/testcasecontroller/algorithm/module/module.py.

However, both Incremental Learning and Joint Inference require Sedna itself to load this module, which causes issues in #136.

I solved the problem by adding an if-else branch to specially handle HEM to the parameter format required by Sedna during module loading.

Which issue(s) this PR fixes:

Fixes #136

@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 6, 2024
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign moorezheng after the PR has been reviewed.
You can assign the PR to them by writing /assign @moorezheng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 6, 2024
@kubeedge-bot kubeedge-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2024
@MooreZheng MooreZheng requested review from hsj576 and removed request for Poorunga September 9, 2024 09:51
@FuryMartin FuryMartin mentioned this pull request Sep 26, 2024
Merged
@FuryMartin
Copy link
Contributor Author

Fixed by #149 .

No need to merge this PR anymore. I will close it.

@FuryMartin FuryMartin closed this Oct 30, 2024
@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2024
@kubeedge-bot
Copy link
Collaborator

@FuryMartin: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MooreZheng MooreZheng Awaiting requested review from MooreZheng

@hsj576 hsj576 Awaiting requested review from hsj576

Assignees

@FuryMartin FuryMartin

@hsj576 hsj576

Labels
kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misalignment of the Hard Example Mining interface with Sedna
3 participants
@FuryMartin @kubeedge-bot @hsj576