From a6c37e4f3a64ca7f626a4d80f1c3f88362bf03a4 Mon Sep 17 00:00:00 2001 From: Shao Wang <77665902+Electronic-Waste@users.noreply.github.com> Date: Thu, 25 Jul 2024 00:03:53 +0800 Subject: [PATCH] fix: remove the dependency of `protocmp` in `google.golang.org/protobuf/testing/protocmp`. (#2391) Signed-off-by: Electronic-Waste <2690692950@qq.com> --- .../file-metricscollector/file-metricscollector_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/metricscollector/v1beta1/file-metricscollector/file-metricscollector_test.go b/pkg/metricscollector/v1beta1/file-metricscollector/file-metricscollector_test.go index 14e505f6ec4..7e8042ef66b 100644 --- a/pkg/metricscollector/v1beta1/file-metricscollector/file-metricscollector_test.go +++ b/pkg/metricscollector/v1beta1/file-metricscollector/file-metricscollector_test.go @@ -27,7 +27,6 @@ import ( commonv1beta1 "github.com/kubeflow/katib/pkg/apis/controller/common/v1beta1" v1beta1 "github.com/kubeflow/katib/pkg/apis/manager/v1beta1" "github.com/kubeflow/katib/pkg/controller.v1beta1/consts" - "google.golang.org/protobuf/testing/protocmp" ) func TestCollectObservationLog(t *testing.T) { @@ -321,7 +320,8 @@ invalid INFO {metricName: loss, metricValue: 0.3634}`, if diff := cmp.Diff(test.wantError, err, cmpopts.EquateErrors()); len(diff) != 0 { t.Errorf("Unexpected error (-want,+got):\n%s", diff) } - if diff := cmp.Diff(test.expected, actual, protocmp.Transform()); len(diff) != 0 { + observationLogCmpOpts := cmpopts.IgnoreUnexported(v1beta1.ObservationLog{}, v1beta1.MetricLog{}, v1beta1.Metric{}) + if diff := cmp.Diff(test.expected, actual, observationLogCmpOpts); len(diff) != 0 { t.Errorf("Unexpected parsed result (-want,+got):\n%s", diff) } })