Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hooks #2187

Closed
droctothorpe opened this issue Aug 1, 2023 · 3 comments
Closed

Add pre-commit hooks #2187

droctothorpe opened this issue Aug 1, 2023 · 3 comments

Comments

@droctothorpe
Copy link
Contributor

/kind feature

Describe the solution you'd like
Implementing pre-commit hooks would improve code quality and standardization. KFP uses them extensively. They are also executed in CI. We could start small by targeting the SDK with hooks like pysort and docformatter and branch out from there.

Anything else you would like to add:
We'd be happy to contribute this. If you'd like for it to be included in CI, we might need some guidance for where to configure that.


Love this feature? Give it a 👍 We prioritize the features with the most 👍

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member

/lifecycle frozen

@andreyvelich
Copy link
Member

This has been implemented 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants