Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from objectSelector to AdmissionWebhookMatchConditions #2206

Open
tenzen-y opened this issue Aug 15, 2023 · 4 comments · May be fixed by #2241
Open

Switch from objectSelector to AdmissionWebhookMatchConditions #2206

tenzen-y opened this issue Aug 15, 2023 · 4 comments · May be fixed by #2241

Comments

@tenzen-y
Copy link
Member

tenzen-y commented Aug 15, 2023

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
We introduced the objectSelector to avoid deadlock in the phase that the controller creates the webhook certs.

#2203

However, we should switch to AdmissionWebhookMatchConditions to process requests more accurately once the feature-gate is enabled by default.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]


Love this feature? Give it a 👍 We prioritize the features with the most 👍

@lianghao208
Copy link
Member

I think the AdmissionWebhookMatchConditions is in 1.28 beta feature state now, which means the feature-gate is enabled by default.
I will submit a PR to switch it to AdmissionWebhookMatchConditions.

@lianghao208
Copy link
Member

/assign

Copy link

github-actions bot commented Feb 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tenzen-y
Copy link
Member Author

tenzen-y commented Feb 2, 2024

/lifecycle frozen

We will work on this after the next release since we will support k8s v1.27 in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants