From 50cd35a9452746ba742fc0b3bd74019a2113b1b8 Mon Sep 17 00:00:00 2001
From: jaffe-fly <flydemailbox@163.com>
Date: Wed, 17 Jul 2024 21:37:01 +0800
Subject: [PATCH] Update Instructions for Argo Workflow

Signed-off-by: jaffe-fly <flydemailbox@163.com>
---
 examples/v1beta1/argo/README.md | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/examples/v1beta1/argo/README.md b/examples/v1beta1/argo/README.md
index fd320645d3f..8d95330459f 100644
--- a/examples/v1beta1/argo/README.md
+++ b/examples/v1beta1/argo/README.md
@@ -79,15 +79,23 @@ kubectl patch ClusterRole katib-controller -n kubeflow --type=json \
   -p='[{"op": "add", "path": "/rules/-", "value": {"apiGroups":["argoproj.io"],"resources":["workflows"],"verbs":["get", "list", "watch", "create", "delete"]}}]'
 ```
 
-In addition to that, you have to modify Katib
-[Controller args](https://github.com/kubeflow/katib/blob/master/manifests/v1beta1/components/controller/controller.yaml#L27)
-with the new flag `--trial-resources`.
+Run the following command to update [Katib config](https://www.kubeflow.org/docs/components/katib/user-guides/katib-config/#katib-controller-parameters):
 
-Run the following command to update Katib Controller args:
+```bash
+kubectl edit configMap katib-config -n kubeflow
+```
+
+For example, to support Workflow Pipelines, add `Workflow.v1alpha1.argoproj.io` in `trialResources`:
+
+```bash
+trialResources:
+  - Workflow.v1alpha1.argoproj.io
+```
+
+After that, you need to restart the Katib controller Pod:
 
 ```bash
-kubectl patch Deployment katib-controller -n kubeflow --type=json \
-  -p='[{"op": "add", "path": "/spec/template/spec/containers/0/args/-", "value": "--trial-resources=Workflow.v1alpha1.argoproj.io"}]'
+kubectl delete pod -n kubeflow -l katib.kubeflow.org/component=controller
 ```
 
 Check that Katib Controller's pod was restarted:
@@ -107,7 +115,7 @@ Check logs from Katib Controller to verify Argo Workflow integration:
 ```bash
 $ kubectl logs $(kubectl get pods -n kubeflow -o name | grep katib-controller) -n kubeflow | grep '"CRD Kind":"Workflow"'
 
-{"level":"info","ts":1628032648.6285546,"logger":"trial-controller","msg":"Job watch added successfully","CRD Group":"argoproj.io","CRD Version":"v1alpha1","CRD Kind":"Workflow"}
+{"level":"info","ts":"2024-07-13T10:02:10Z","logger":"trial-controller","msg":"Job watch added successfully","CRD Group":"argoproj.io","CRD Version":"v1alpha1","CRD Kind":"Workflow"}
 ```
 
 If you ran the above steps successfully, you should be able to run Argo Workflow examples.