Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic logout URLs in CentralDashboard #6940

Closed
kimwnasptd opened this issue Feb 6, 2023 · 6 comments
Closed

Support dynamic logout URLs in CentralDashboard #6940

kimwnasptd opened this issue Feb 6, 2023 · 6 comments
Labels

Comments

@kimwnasptd
Copy link
Member

/kind bug

We just merged for KF 1.7 RC0 the update on AuthService kubeflow/manifests#2150. But in this commit the logout URL is /authservice/logout, instead of /logout. But since we can't hardcode this value, since not everyone might be using AuthService, we'll need to have a dynamic mechanism for learning this URL.

I'd propose to

  1. have a new ENV Var LOGOUT_URL in the Deployment of the app
  2. The backend will add this for the /api/workgroup/env-info route handler https://github.com/kubeflow/kubeflow/blob/master/components/centraldashboard/app/api_workgroup.ts
  3. The frontend will dynamically use this value from the backend

This way users can configure the app based on the authentication service that they use in a dynamic way

@kimwnasptd
Copy link
Member Author

There's already an in-flight PR that tries to fix the logout behaviour #6609

We can try to fix the issue in that or create a separate one. This fix is something we'd like to track for the KF 1.7 release cc @DomFleischmann

@DomFleischmann
Copy link

Thank you for the heads up @kimwnasptd , yes I believe this is something we want to get fixed for this release.

@orfeas-k
Copy link
Contributor

I sent the PR for this here.

For documentation, I followed this as a guideline in order to bind data between Polymer components. In Polymer, in order to bind values to a property of a child element, one has to use dash-case syntax instead of camel case (which is how what is being used to create the property). On top of that, in order to use a property as a DOM element's attribute, the syntax is this

attribute$={{element-property}}

@ajinkya933
Copy link

ajinkya933 commented Nov 29, 2023

your PR routes me to localhost:8888/authservice/site/after_logout with a blank page as a response. Is there a way by which I can hardcode a website ( google.com ) to route to after logout button is clicked (provided the logout clears all cache)
cc @orfeas-k @kimwnasptd

@juliusvonkohout
Copy link
Member

/close

since the PR is merged and oidc-authservice is gone in Kubeflow 1.9.1

Copy link

@juliusvonkohout: Closing this issue.

In response to this:

/close

since the PR is merged and oidc-authservice is gone in Kubeflow 1.9.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants