-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dynamic logout URLs in CentralDashboard #6940
Comments
There's already an in-flight PR that tries to fix the logout behaviour #6609 We can try to fix the issue in that or create a separate one. This fix is something we'd like to track for the KF 1.7 release cc @DomFleischmann |
Thank you for the heads up @kimwnasptd , yes I believe this is something we want to get fixed for this release. |
I sent the PR for this here. For documentation, I followed this as a guideline in order to bind data between Polymer components. In Polymer, in order to bind values to a property of a child element, one has to use
|
your PR routes me to |
/close since the PR is merged and oidc-authservice is gone in Kubeflow 1.9.1 |
@juliusvonkohout: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind bug
We just merged for KF 1.7 RC0 the update on AuthService kubeflow/manifests#2150. But in this commit the logout URL is
/authservice/logout
, instead of/logout
. But since we can't hardcode this value, since not everyone might be using AuthService, we'll need to have a dynamic mechanism for learning this URL.I'd propose to
LOGOUT_URL
in the Deployment of the app/api/workgroup/env-info
route handler https://github.com/kubeflow/kubeflow/blob/master/components/centraldashboard/app/api_workgroup.tsThis way users can configure the app based on the authentication service that they use in a dynamic way
The text was updated successfully, but these errors were encountered: