Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a better solution for using images built in PRs in deploy-kfp.sh #11293

Open
Tracked by #11290
hbelmiro opened this issue Oct 13, 2024 · 5 comments
Open
Tracked by #11290

Find a better solution for using images built in PRs in deploy-kfp.sh #11293

hbelmiro opened this issue Oct 13, 2024 · 5 comments

Comments

@hbelmiro
Copy link
Contributor

hbelmiro commented Oct 13, 2024

Currently deploy-kfp.sh is patching the deployments to set the images. We need to find a better solution. Maybe using kustomize?

This issue depends on:

Labels

/area testing


Impacted by this bug? Give it a 👍.

@CarterFendley
Copy link
Contributor

What's up homies.

I opened #11294 to add this for Argo setups. It looks like the tekton action already uses a kustomization.yaml for its' setup.

This file has configurations for the apiserver, persistenceagent, and scheduledworkflow but no patches for the driver / launcher. Since all of this stuff is the same, I am wondering if I should try to pull out these images configurations into a common file?

I am not 100% certain on the tekton side of things, so please add info where helpful.

@hbelmiro
Copy link
Contributor Author

I believe both ArgoWF and Tekton use the same images.
@rimolive can you confirm it?

@rimolive
Copy link
Member

Not really. In KFP 2.2.0 we did not finish the kfp-tekton code merge, so if you need to use tekton you will still require a separate image.

@hbelmiro hbelmiro changed the title Find a better solution for using images built in PRs in deploy-kfp-tekton.sh and deploy-kfp.sh Find a better solution for using images built in PRs in deploy-kfp.sh Oct 15, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Dec 15, 2024
@hbelmiro
Copy link
Contributor Author

/lifecycle frozen

@google-oss-prow google-oss-prow bot added lifecycle/frozen and removed lifecycle/stale The issue / pull request is stale, any activities remove this label. labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants