Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze eksctl version in aws image #972

Closed
wants to merge 3 commits into from
Closed

Freeze eksctl version in aws image #972

wants to merge 3 commits into from

Conversation

theofpa
Copy link
Member

@theofpa theofpa commented Dec 11, 2021

Which issue is resolved by this Pull Request:
Resolves #971

Description of your changes:
Freezing eksctl in the aws test image to prevent breaking the tests workflow if a future eksctl version will remove the support for k8s-1.18 version.

Checklist:

If PR related to Optional-Test-Infra,

  • Changes need to be generated to aws/GitOps folder:
    1. cd aws
    2. make optional-generate
    3. make optional-test

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: theofpa
To complete the pull request process, please assign patrickxys after the PR has been reviewed.
You can assign the PR to them by writing /assign @patrickxys in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y tenzen-y mentioned this pull request Dec 12, 2021
Merged
@kimwnasptd
Copy link
Member

That's awesome @theofpa! One small question, just to confirm. The 0.76 version of eksctl supports EKS versions all the way to 1.21?

@kimwnasptd kimwnasptd mentioned this pull request Feb 7, 2022
Merged
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been closed due to inactivity.

@stale stale bot closed this Apr 27, 2022
@tenzen-y tenzen-y mentioned this pull request May 3, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Awaiting requested review from Bobgy

@jlewi jlewi Awaiting requested review from jlewi

@pingsutw pingsutw Awaiting requested review from pingsutw

Assignees
No one assigned
Labels
lifecycle/stale size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eksctl latest release will break cluster setup
2 participants
@theofpa @kimwnasptd