From 5baabfb5f2e05e64f92d5ac405aea368d91f0166 Mon Sep 17 00:00:00 2001 From: bobz965 Date: Thu, 8 Aug 2024 15:56:03 +0800 Subject: [PATCH] fix: should delete subnet before vpc (#4370) Signed-off-by: bobz965 --- pkg/controller/vpc.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkg/controller/vpc.go b/pkg/controller/vpc.go index 493a45d1a21..b5bd67ac483 100644 --- a/pkg/controller/vpc.go +++ b/pkg/controller/vpc.go @@ -117,6 +117,13 @@ func (c *Controller) handleDelVpc(vpc *kubeovnv1.Vpc) error { defer func() { _ = c.vpcKeyMutex.UnlockKey(vpc.Name) }() klog.Infof("handle delete vpc %s", vpc.Name) + // should delete vpc subnets first + if len(vpc.Status.Subnets) != 0 { + err := fmt.Errorf("failed to delete vpc %s, still has subnets %v", vpc.Name, vpc.Status.Subnets) + klog.Error(err) + return err + } + if err := c.deleteVpcLb(vpc); err != nil { klog.Error(err) return err