Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add default namespace in examples to fix e2e test failure #733

Merged
merged 2 commits into from
Aug 9, 2024
Merged

test: add default namespace in examples to fix e2e test failure #733

merged 2 commits into from
Aug 9, 2024

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
test: add default namespace in examples to fix e2e test failure

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Aug 9, 2024
@k8s-ci-robot k8s-ci-robot requested a review from carlory August 9, 2024 08:15
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from gnufied August 9, 2024 08:15
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 9, 2024
@coveralls
Copy link

coveralls commented Aug 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10317180870

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.831%
Totals Coverage Status
Change from base Build 10294581952: 0.0%
Covered Lines: 890
Relevant Lines: 1129
💛 - Coveralls

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit 59364a0 into kubernetes-csi:master Aug 9, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlory carlory Awaiting requested review from carlory

@gnufied gnufied Awaiting requested review from gnufied

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhangx @k8s-ci-robot @coveralls