Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release lease on SIGTERM #609

Open
jsafrane opened this issue Dec 13, 2024 · 0 comments
Open

Release lease on SIGTERM #609

jsafrane opened this issue Dec 13, 2024 · 0 comments

Comments

@jsafrane
Copy link
Contributor

jsafrane commented Dec 13, 2024

When the sidecar is terminating because of SIGTERM, it should finish all running operations + release its leader election lease. This will allow another attacher sidecar to pick the lease quickly, without waiting for leader election timeouts.

"Finish all running operations" could be accomplished by cancelling a global context.Context +waiting for workqueues to finish.

This affects all sidecars, using the attacher to agree on a solution + a testable PR that can then be copied to all sidecars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant