diff --git a/pkg/cloud/volume_limits.go b/pkg/cloud/volume_limits.go index 3488e7473b..38c726f60f 100644 --- a/pkg/cloud/volume_limits.go +++ b/pkg/cloud/volume_limits.go @@ -558,8 +558,9 @@ var gpuInstanceGpus = map[string]int{ } // Note this table is not a reflection of how many accelerators an instance has but of how many slots their combined acclerators take up -// VT instance type accelerators take two slots each with the exception of the vt1.24xlarge which takes 0 slots for its acclerators +// VT instance type acclerators take two slots each with the exception of the vt1.24xlarge which takes 0 slots for its acclerators // inf1 instance types are purposely not added to this table as they are in the maxVolumeLimits table +// https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/volume_limits.html var acceleratorSlotsTaken = map[string]int{ "vt1.3xlarge": 2, "vt1.6xlarge": 4, diff --git a/pkg/driver/node_test.go b/pkg/driver/node_test.go index 26e171c432..92e441345f 100644 --- a/pkg/driver/node_test.go +++ b/pkg/driver/node_test.go @@ -1249,7 +1249,7 @@ func TestGetVolumesLimit(t *testing.T) { }, }, { - // will and should fail if inf1.xlarge instance type is in any table other than maxVolumeLimits table + // Should fail if inf1.xlarge instance type is in any table other than maxVolumeLimits table name: "inf1.xlarge_volume_attach_limit (Instance has attached Accelerators but should be ignored for EBS volume limits calculation)", options: &Options{ VolumeAttachLimit: -1, @@ -1266,7 +1266,7 @@ func TestGetVolumesLimit(t *testing.T) { }, }, { - // will and should fail if inf1.xlarge instance type is in any table other than maxVolumeLimits table + // Should fail if inf1.xlarge instance type is in any table other than maxVolumeLimits table name: "inf1.2xlarge_volume_attach_limit (Instance has attached Accelerators but should be ignored for EBS volume limits calculation)", options: &Options{ VolumeAttachLimit: -1, @@ -1283,7 +1283,7 @@ func TestGetVolumesLimit(t *testing.T) { }, }, { - // will and should fail if inf1.6xlarge instance type is in any table other than maxVolumeLimits table + // Should fail if inf1.6xlarge instance type is in any table other than maxVolumeLimits table name: "inf1.6xlarge_volume_attach_limit (Instance has attached Accelerators but should be ignored for EBS volume limits calculation)", options: &Options{ VolumeAttachLimit: -1, @@ -1300,7 +1300,7 @@ func TestGetVolumesLimit(t *testing.T) { }, }, { - // will and should fail if inf1.24xlarge instance type is in any table other than maxVolumeLimits table + // Should fail if inf1.24xlarge instance type is in any table other than maxVolumeLimits table name: "inf1.24xlarge_volume_attach_limit (Instance has attached Accelerators but should be ignored for EBS volume limits calculation)", options: &Options{ VolumeAttachLimit: -1,