Add Github actions code coverage CI job #1762
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Signed-off-by: Connor Catlett <[email protected]>
| - name: Set up go | ||
| uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: '^1.20.2' |
There was a problem hiding this comment.
Maybe overkill, but can we avoid hardcoding with an env var? https://stackoverflow.com/questions/74021760/how-to-use-environment-variables-on-github-actions-without-hard-coding-them-is
There was a problem hiding this comment.
I'm not sure I understand what you're suggesting? Can you clarify?
There was a problem hiding this comment.
We currently hardcode the go version for other workflows as well but its a good idea to grab it from go mod using go-version-file : https://github.com/actions/setup-go#getting-go-version-from-the-gomod-file.
|
|
||
| - name: Generate report | ||
| run: | | ||
| go test -coverprofile base-coverage.tmp ./cmd/... ./pkg/... |
There was a problem hiding this comment.
Any chance we can get the -html=coverage.out as an artifact and link the file in the comment?
There was a problem hiding this comment.
I don't believe so, as we would have to host it somewhere. As far as I can tell GitHub does not host artifacts for you.
I do have an idea to show the code coverage output on the prow test runs, but didn't think it was appropriate for this PR (and might not be possible? needs more investigation)
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Is this a bug fix or adding new feature?
"New feature" for CI
What is this PR about? / Why do we need it?
Adds a GitHub Actions CI job to diff code coverage and comment the difference on the PR.
What testing is done?
Note: although the PR jobs will run on this PR, the comment job must be committed to
masterbefore it can run. See example runs below:Example with decrease: ConnorJC3#2
Example with no change: ConnorJC3#3
Example with increase: ConnorJC3#5
Example with external contributor: ConnorJC3#6