make manifests fails with aws_manager_image_patch.yaml: no such file or directory

[babu-selector]

/kind bug

sigs.k8s.io/cluster-api-provider-aws $ make manifests
go run vendor/sigs.k8s.io/controller-tools/cmd/controller-gen/main.go crd
CRD files generated, files can be found under path /Users/babu-s2/go/src/sigs.k8s.io/cluster-api-provider-aws/config/crds.
kustomize build config/default/ > cmd/clusterctl/examples/aws/out/provider-components.yaml
Error: SliceFromPatches: open /Users/babu-s2/go/src/sigs.k8s.io/cluster-api-provider-aws/cmd/clusterctl/examples/aws/out/aws_manager_image_patch.yaml: no such file or directory

What did you expect to happen:
The startup guide steps are broken, not working as mentioned.

Anything else you would like to add:

Workaround is to run ./generate-yaml.sh explicitly

Environment:

• Cluster-api-provider-aws version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

[ashish-amarnath]

https://kubernetes.slack.com/archives/CD6U2V71N/p1547570376262000
The workaround was to run make clean manifests

[ashish-amarnath]

@rdodev Do you have anything more to add here?

[rdodev]

Sorry @ashish-amarnath didn't get notifications until now. Let me check it out.

[rdodev]

@babu-selector is right. I think the docs seems to be missing steps or provide incomplete info. Both the make clean && make manifests and then using Jason's gist helped for instructions not using minikube.

[chuckha]

This will be going away as we start merging in pieces of #310. I'll track the work but I don't think this needs to be fixed independently of the Makefile changes

/lifecycle active

[randomvariable]

Fixed in #580

Removed aws_manager_image_patch.yaml completely, so this issue will no longer apply.

/close

[k8s-ci-robot]

@randomvariable: Closing this issue.

In response to this:

Fixed in #580

Removed aws_manager_image_patch.yaml completely, so this issue will no longer apply.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.