Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release management #673

Closed
ashish-amarnath opened this issue Mar 19, 2019 · 2 comments · Fixed by #682
Closed

Improve release management #673

ashish-amarnath opened this issue Mar 19, 2019 · 2 comments · Fixed by #682
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@ashish-amarnath
Copy link
Contributor

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
As a CAPA user, I would like to be able to answer questions like:

  • What commit was a controller image tag built at?
  • What manifest versions are compatible with which controller image tags

Coupling the release version and the image tag will help in user troubleshooting and ensuring compatibility.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 19, 2019
@randomvariable
Copy link
Member

Concretely, the image tag for v0.1.1 release is actually 0.0.5, which is confusing to consumers of Cluster API Provider AWS.

Although this was removed to allow the semi-automated release process to work properly, some of the intent in #580 was as follows:

  • Moving versioning into .bazelrc, meant a commit could be checked out and it would be clear which release artifacts were still valid. The idea being that for a release, a developer would do the following:
  1. Tag release
  2. CI system picks up tag and runs release pipeline
  3. Bump version in .bazelrc to next release and commit

As far as the controller goes, #433 should be repeated for the manager, and optionally consider pushing additional image tags related to commit id and other version specific metadata.

I have updated the release at https://github.com/kubernetes-sigs/cluster-api-provider-aws/releases/tag/v0.1.1 to explicitly state the controller image for now.

@detiber
Copy link
Member

detiber commented Mar 27, 2019

/milestone v1alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants