✨ Support BYO Public IPv4 Pool when provision infrastructure #4905

mtulio · 2024-04-03T19:13:55Z

What type of PR is this?

/kind feature
/kind api-change
/kind documentation

What this PR does / why we need it:

Introducing support of PublicIpv4Pool to provision base cluster infrastructure consuming public IPv4 (EIP) from a custom Public IPv4 pool brought to AWS.

A subset of changes of this PR is isolated into those PRs:

Which issue(s) this PR fixes

Fixes #4887

Special notes for your reviewer:

The changes proposes to create Elastic IPs for each resource and zone claiming public IP address when creating the core infrastructure components and Machines in public subnets. The components supported for core infrastructure are Nat Gateways and Network Load Balancer for API server.

Checklist:

Release note:

Introduce the support of provisioning public IPv4 address consuming from a custom Public IPv4 Pool that is brought to AWS. When the field `PublicIpv4Pool` is set with the pool ID, all the network resources which claims public IPv4, such as Network Load Balancers and NAT Gateways, will be created consuming from the custom pool.

k8s-ci-robot · 2024-04-03T19:14:04Z

Hi @mtulio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mtulio

Temporary changes to test locally as it has been addressed in #4892 . It will be removed once merged/rebased;

pkg/cloud/services/ec2/instances.go

api/v1beta2/types.go

mtulio · 2024-04-29T22:21:46Z

prevent WIP notifications
/uncc Ankitasw dlipovetsky

mtulio · 2024-04-30T05:44:29Z

/test pull-cluster-api-provider-aws-e2e

k8s-ci-robot · 2024-04-30T05:44:44Z

@mtulio: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-cluster-api-provider-aws-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mtulio · 2024-04-30T05:46:31Z

HI @damdo @nrb - can I have labels to test in this PR? Thanks

damdo · 2024-04-30T07:22:23Z

/ok-to-test

api/v1beta2/network_types.go

docs/book/src/topics/bring-your-own-aws-infrastructure.md

pkg/cloud/services/ec2/instances_test.go

linux-foundation-easycla · 2024-06-03T19:29:12Z

The committers listed above are authorized under a signed CLA.

✅ login: mtulio / name: Marco Braga (2f230b3)

jcpowermac · 2024-06-04T12:10:11Z

/test pull-cluster-api-provider-aws-test

damdo · 2024-06-07T20:07:37Z

/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e-conformance

Introducing support of BYO Public IPv4 Pool to allow CAPA allocate IPv4 Elastic IPs from user-provided IPv4 pools that was brought to AWS when provisioning base cluster infrastructure. This change introduce the API fields: - AWSCLuster NetworkSpec.ElasticIPPool: allowing the controllers to consume from user-provided public pools when provisioning core components from the infrastructure, like Nat Gateways and public Network Load Balancer (API server only) - AWSMachine ElasticIPPool: allowing the machine to consume from BYO Public IPv4 pool when the instance is deployed in the public subnets. The ElasticIPPool structure defines a custom IPv4 Pool (previously created in the AWS Account) to teach controllers to set the pool when creating public ip addresses (Elastic IPs) for components which requires it, such as Nat Gateways and NLBs.

mtulio · 2024-06-07T20:47:33Z

Thanks @jcpowermac and @rvanderp3 for taking care of this PR addressing the review while I was out.

/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e-conformance

Hey @damdo - apologies I killed the jobs while addressing this comment. Let me trigger again:

/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e-conformance

mtulio · 2024-06-07T22:49:26Z

/test pull-cluster-api-provider-aws-e2e-eks

mtulio · 2024-06-08T04:01:54Z

/test pull-cluster-api-provider-aws-e2e-eks

Unrelated issue:

STEP: Event details for AWSIAMUserBootstrapper : Resource: AWS::IAM::User, Status: CREATE_FAILED, Reason: Resource handler returned message: "Resource of type 'AWS::IAM::User' with identifier 'bootstrapper.cluster-api-provider-aws.sigs.k8s.io' already exists." (RequestToken: fb13356d-5ac6-1c5f-1b83-6ea7aad87fb4, HandlerErrorCode: AlreadyExists) @ 06/07/24 23:02:31.865

STEP: Event details for cluster-api-provider-aws-sigs-k8s-io : Resource: AWS::CloudFormation::Stack, Status: ROLLBACK_IN_PROGRESS, Reason: The following resource(s) failed to create: [AWSIAMManagedPolicyControllers, AWSIAMInstanceProfileControllers, AWSIAMInstanceProfileNodes, AWSIAMInstanceProfileControlPlane, AWSIAMManagedPolicyControllersEKS, AWSIAMUserBootstrapper]. Rollback requested by user. @ 06/07/24 23:02:31.865

Looking the IAM resource name "Resource of type 'AWS::IAM::User' with identifier 'bootstrapper.cluster-api-provider-aws.sigs.k8s.io' already exists it seems not to be specific for this job run, it makes me wonder if that job supports parallel executions. cc @damdo @nrb

I will trigger again with a, hopefully, low traffic period (Friday night =] ).

/test pull-cluster-api-provider-aws-e2e-eks

nrb · 2024-06-12T02:20:12Z

Thanks for your diligence and patience with this @mtulio!

/approve

k8s-ci-robot · 2024-06-12T02:20:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nrb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

damdo

Thanks for the great work here @mtulio & others!
/lgtm

Create support on installer to setup BYO Public Ipv4 pool feature from CAPA while provisioning the cluster when the config platform.aws.publicIpv4Pool is set. kubernetes-sigs/cluster-api-provider-aws#4905 The feature will tell the provisioner, CAPA, to claim EIPs from a custom Public IPv4 pool which the user provisioned and advertised to AWS, when creating infrastructure resources in public subnets, such as NAT Gateways, API's NLB, and bootstrap. This is a feature parity added on Terraform in 4.16: openshift#7983

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 3, 2024

k8s-ci-robot requested review from Ankitasw and dlipovetsky April 3, 2024 19:14

mtulio mentioned this pull request Apr 3, 2024

OCPBUGS-35504: SPLAT-1437: CAPI/AWS/BYOIP: supporting Public IPv4 Pool openshift/installer#8175

Merged

mtulio commented Apr 3, 2024

View reviewed changes

pkg/cloud/services/ec2/instances.go Outdated Show resolved Hide resolved

pkg/cloud/services/ec2/instances.go Outdated Show resolved Hide resolved

api/v1beta2/types.go Outdated Show resolved Hide resolved

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 4, 2024

mtulio force-pushed the SPLAT-1437-capa-byoip branch from dad9f3c to 994196a Compare April 29, 2024 22:08

k8s-ci-robot removed request for dlipovetsky and Ankitasw April 29, 2024 22:21

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024

mtulio force-pushed the SPLAT-1437-capa-byoip branch from 994196a to fa1f162 Compare April 30, 2024 05:36

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 30, 2024

mtulio force-pushed the SPLAT-1437-capa-byoip branch from fa1f162 to 4c41955 Compare April 30, 2024 05:46

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2024

nrb reviewed May 28, 2024

View reviewed changes

api/v1beta2/network_types.go Outdated Show resolved Hide resolved

nrb reviewed May 28, 2024

View reviewed changes

api/v1beta2/network_types.go Outdated Show resolved Hide resolved

nrb reviewed May 28, 2024

View reviewed changes

docs/book/src/topics/bring-your-own-aws-infrastructure.md Outdated Show resolved Hide resolved

nrb reviewed May 28, 2024

View reviewed changes

pkg/cloud/services/ec2/instances_test.go Outdated Show resolved Hide resolved

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2024

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 3, 2024

jcpowermac force-pushed the SPLAT-1437-capa-byoip branch from 4bba41a to 3648331 Compare June 3, 2024 19:46

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 4, 2024

jcpowermac force-pushed the SPLAT-1437-capa-byoip branch from 3648331 to a62b90d Compare June 4, 2024 14:03

mtulio force-pushed the SPLAT-1437-capa-byoip branch from d1c6604 to 2f230b3 Compare June 7, 2024 20:38

nrb added this to the v2.6.0 milestone Jun 11, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024

damdo reviewed Jun 12, 2024

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2024

k8s-ci-robot merged commit be020fd into kubernetes-sigs:main Jun 12, 2024
23 checks passed

mtulio deleted the SPLAT-1437-capa-byoip branch June 12, 2024 13:11

r4f4 mentioned this pull request Jun 14, 2024

OCPBUGS-34819: capi/aws: bump provider for fixes openshift/installer#8545

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Support BYO Public IPv4 Pool when provision infrastructure #4905

✨ Support BYO Public IPv4 Pool when provision infrastructure #4905

mtulio commented Apr 3, 2024 •

edited

Loading

k8s-ci-robot commented Apr 3, 2024

mtulio left a comment

mtulio commented Apr 29, 2024

mtulio commented Apr 30, 2024

k8s-ci-robot commented Apr 30, 2024

mtulio commented Apr 30, 2024 •

edited

Loading

damdo commented Apr 30, 2024

linux-foundation-easycla bot commented Jun 3, 2024 •

edited

Loading

jcpowermac commented Jun 4, 2024

damdo commented Jun 7, 2024

mtulio commented Jun 7, 2024

mtulio commented Jun 7, 2024

mtulio commented Jun 8, 2024

nrb commented Jun 12, 2024

k8s-ci-robot commented Jun 12, 2024

damdo left a comment

✨ Support BYO Public IPv4 Pool when provision infrastructure #4905

✨ Support BYO Public IPv4 Pool when provision infrastructure #4905

Conversation

mtulio commented Apr 3, 2024 • edited Loading

k8s-ci-robot commented Apr 3, 2024

mtulio left a comment

Choose a reason for hiding this comment

mtulio commented Apr 29, 2024

mtulio commented Apr 30, 2024

k8s-ci-robot commented Apr 30, 2024

mtulio commented Apr 30, 2024 • edited Loading

damdo commented Apr 30, 2024

linux-foundation-easycla bot commented Jun 3, 2024 • edited Loading

jcpowermac commented Jun 4, 2024

damdo commented Jun 7, 2024

mtulio commented Jun 7, 2024

mtulio commented Jun 7, 2024

mtulio commented Jun 8, 2024

nrb commented Jun 12, 2024

k8s-ci-robot commented Jun 12, 2024

damdo left a comment

Choose a reason for hiding this comment

mtulio commented Apr 3, 2024 •

edited

Loading

mtulio commented Apr 30, 2024 •

edited

Loading

linux-foundation-easycla bot commented Jun 3, 2024 •

edited

Loading