Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dualstack vmss cluster stuck at namespace deletion with old k8s version #4347

Closed
lzhecheng opened this issue Dec 8, 2023 · 11 comments
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@lzhecheng
Copy link
Contributor

/kind bug

[Before submitting an issue, have you checked the Troubleshooting Guide?]

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
For dualstack vmss CI with k8s version 1.27.1, clusters were stuck at namespace deletion. I deployed the same cluster locally and it also fails.

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/cloud-provider-azure-master-dualstack-vmss-capz/1732852687860404224

What did you expect to happen:
Old k8s version is also supported.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 8, 2023
@CecileRobertMichon
Copy link
Contributor

@lzhecheng I'm seeing the following errors in the logs:

      --------------------------------------------------------------------------------
      RESPONSE 404: 404 Not Found
      ERROR CODE: ResourceGroupNotFound
      --------------------------------------------------------------------------------
      {
        "error": {
          "code": "ResourceGroupNotFound",
          "message": "Resource group 'capz-cfoe84' could not be found."
        }
      }
      --------------------------------------------------------------------------------

Is it possible something is deleting the resource group during the test?

@CecileRobertMichon
Copy link
Contributor

Actually the rg is getting deleted before the test finishes running because the test is taking 5 hours due to all the test timeouts and all RGs older than 4 hours are deleted by the rg cleanup job

So the RG deletion doesn't seem to be the cause of the issue

It looks like the latest run with 1.28 is failing the same way: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/cloud-provider-azure-master-dualstack-vmss-capz/1733215008105435136

@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Dec 9, 2023

I believe you are hitting a bug with the newest version of containerd, you need the same workaround applied in #4209 to https://github.com/kubernetes-sigs/cloud-provider-azure/blob/master/tests/k8s-azure/manifest/cluster-api/cluster-template-prow-dual-stack-mp.yaml

Side note: would you be able to use the CAPZ template for this test (https://github.com/CecileRobertMichon/cluster-api-provider-azure/blob/main/templates/test/ci/cluster-template-prow-dual-stack.yaml) ? It has both VMSS and VMs

What is https://github.com/kubernetes-sigs/cloud-provider-azure/blob/master/tests/k8s-azure/manifest/cluster-api/cluster-template-prow-dual-stack-mp.yaml adding that is not already covered in the CAPZ template?

Edit: instead of adding the restart containerd workaround you should be able to do #4350 directly

@lzhecheng
Copy link
Contributor Author

lzhecheng commented Dec 11, 2023

@CecileRobertMichon Thank you. I will try it.
I'm willing to use capz templates but I want to create a cluster with only vmss.
I think there're 2 solutions:

  1. Use 2 variables for workload count in capz templates, and by default set both to be the same. Then I can specify one variable be 0 in my testing.
  2. I need to update cloud-provider-azure test code to be able to run on only vmss nodes or vm nodes. This solution needs some effort to go through all GetPod/CreatePod functions for example.

@lzhecheng
Copy link
Contributor Author

@CecileRobertMichon Another question:
I thought the only difference between these 2 templates is that the first support KUBERNETES_VERSION: latest. However, the first one has MachineDeployment but the second one has MachineDeployment and MachinePool. Why this difference?

templates/test/ci/cluster-template-prow-ci-version-ipv6.yaml
templates/test/ci/cluster-template-prow-ipv6.yaml

@CecileRobertMichon
Copy link
Contributor

I don't think that difference is intentional, we should add a MachinePool to the ci-version template as well

@lzhecheng
Copy link
Contributor Author

I don't think that difference is intentional, we should add a MachinePool to the ci-version template as well

I created an issue for it

@willie-yao willie-yao added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jan 25, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 24, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 24, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
Archived in project
Development

No branches or pull requests

5 participants