Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃extend ci-conformance.sh testing capability #428

Closed
sayantani11 opened this issue Sep 27, 2021 · 21 comments
Closed

🏃extend ci-conformance.sh testing capability #428

sayantani11 opened this issue Sep 27, 2021 · 21 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@sayantani11
Copy link
Contributor

sayantani11 commented Sep 27, 2021

/kind feature

Extending ci-conformance.sh testing capability to allow other tests to be run on a CAPZ cluster - a temporary solution until kubernetes-sigs/cluster-api#2826 is fixed.

Describe the solution you'd like

[A clear and concise description of what you want to happen.]
ci-entrypoint.sh will be the new entrypoint for all E2E tests. It can accept k/k master branch or release branches, and has the option to run upstream E2E tests or bring your own E2E tests by appending custom commands to ./scripts/ci-entrypoint.sh.

Anything else you would like to add:

Refer to: kubernetes-sigs/cluster-api-provider-azure#617
https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/scripts/ci-entrypoint.sh
As of now try adding the scripts/ci-entrypoint.sh file, and as we move forward we could see for the rest.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 27, 2021
@MadhavJivrajani
Copy link

MadhavJivrajani commented Sep 27, 2021

@sayantani11 please ensure that the issue contains sufficient context and information about what exactly needs to be done so that a new contributor can pick it up with almost 0 barrier to entry. The guidelines for good-first-issues can be found here.

/remove-good-first-issue
Please feel free to re-apply once sufficient information has been added.

@k8s-ci-robot k8s-ci-robot removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Sep 27, 2021
@sayantani11
Copy link
Contributor Author

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@sayantani11:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Sep 27, 2021
@Darshnadas
Copy link

Can I take this issue?

@MadhavJivrajani
Copy link

/assign @Darshnadas

@sayantani11
Copy link
Contributor Author

@Darshnadas You will see a PR reference we are looking for something similar, but as of now our main focus will be the ci-entrypoint.sh file. I have attached the reference to the file with latest update. This script is present in CAPZ and we are wanting the same for CAPG. For the variables in the script, you might try having a look at https://github.com/kubernetes-sigs/cluster-api-provider-gcp/blob/main/docs/book/src/topics/prerequisites.md#setup-environment-variables. For the ensure scripts try looking at the hack folder. And for any problems, we can start a thread in Slack if you want.

@PranshuSrivastava
Copy link

Can i also work on this issue?

@PranshuSrivastava
Copy link

/assign

@Darshnadas
Copy link

@sayantani11 Sure, a thread starting in a slack sounds good

@sayantani11
Copy link
Contributor Author

@PranshuSrivastava as you can see @Darshnadas has claimed the issue, so I think one person will be okay for the PR. You can still browse through the project and see if there are other changes that you could introduce for enhancement of the project. Hope you understand🙂
/unassign @PranshuSrivastava

@PranshuSrivastava
Copy link

@sayantani11 Sure, no problem!

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2021
@Darshnadas
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2021
@mehabhalodiya
Copy link
Contributor

mehabhalodiya commented Feb 7, 2022

@sayantani11 I would like to work on this if nobody else is doing so.

@mehabhalodiya
Copy link
Contributor

/assign

@sayantani11
Copy link
Contributor Author

@mehabhalodiya There's a PR but guess that needs improvement, you can still work on it

@mehabhalodiya
Copy link
Contributor

@Darshnadas I see you are working on this. Let me know if you wouldn't, I can continue 🙂

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 8, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 7, 2022
@sayantani11
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@sayantani11: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants