Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep Floating IP when deleting bastion host #2157

Open
anders-elastisys opened this issue Aug 15, 2024 · 3 comments · May be fixed by #2257
Open

Keep Floating IP when deleting bastion host #2157

anders-elastisys opened this issue Aug 15, 2024 · 3 comments · May be fixed by #2257
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@anders-elastisys
Copy link

anders-elastisys commented Aug 15, 2024 •
edited
Loading

/kind feature

Describe the solution you'd like
I want to have the option (or as default behavior) to keep the floating IP of the bastion host when deleting it if it is specified in openstackcluster.spec.bastion.floatingIP. There were some discussions about keeping floating IPs in this issue, but this does not seem to be the case for bastions atm.

Anything else you would like to add:
I believe this is the part that would need to be changed.
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 15, 2024
@anders-elastisys
Copy link
Author

I tried implementing a fix for this myself which can be seen here. The idea is that as long as a floatingIP is set in the bastion spec of the openstackcluster resource, that floatingIP should not be deleted. I have tested this in a cluster and it seems to work fine as deleting the bastion host will just release its floatingIP with this change, but this can probably be improved and require tests.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2024
@anders-elastisys
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 18, 2024
@anders-elastisys anders-elastisys linked a pull request Nov 18, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
CAPO Roadmap
Status: Inbox
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not delete bastion floating ip if set in spec anders-elastisys/cluster-api-provider-openstack
3 participants
@k8s-ci-robot @k8s-triage-robot @anders-elastisys