-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify Conformance Expectations for Gateway Ports and Listeners #1842
Comments
/help |
@shaneutt: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It would be nice if this was "Core" and didn't require unique manual configuration of each implementation to support.
A use case here is how easy it is to manage multiple certificates on a gateway. Adding multiple listeners with the same port but different An alternative that scales better in K8s clusters would be #1713
Is there a list of standard combinations? |
I created a PR (#1859) that includes a conformance tests for dynamic listener ports |
Note: the TLS examples on the website here show multiple listeners using the same port |
This is one we can't decide from first principles, we need to review implementations and see what can be done first, so that we can build a baseline. It's definitely been my expectation that the tuple that controls "distinct listener" includes, at least: Protocol, Port, TLS details, and name if present. So sharing a Port and Protocol is okay if the TLS details are distinct. I don't know if this is the common view however. |
@youngnick To clarify, are you including "Hostname" in the general category of "TLS Details"? So far we've said that the combination of "Hostname", "Protocol", and "Port" must be unique for each listener. I think that would cover your use case if I'm understanding it correctly. |
FYI with #2065 merging we now have gateway-api/apis/v1beta1/gateway_types.go Lines 72 to 79 in 7c7c0b3
|
I think we can close this now that #2065 has merged. Feel free to reopen if I missed anything. |
What would you like to be added:
As described in #1827 (comment), it would be helpful to describe what we expect from implementations in terms of supported combinations of ports, protocols, and listeners. It seems like the minimum bar is that L7 implementations can handle one HTTP listener on 80 and one HTTPS listener on 443.
What is less clear is what happens beyond that:
Why this is needed:
There's some variation among implementations in terms of what's supported today, it would be good to ensure expectations are clearly stated for conformance.
The text was updated successfully, but these errors were encountered: