Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPCRoute docs on matching rules are unclear #3229

Open
rauanmayemir opened this issue Jul 30, 2024 · 2 comments
Open

GRPCRoute docs on matching rules are unclear #3229

rauanmayemir opened this issue Jul 30, 2024 · 2 comments
Labels
kind/documentation Categorizes issue or PR as related to documentation. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@rauanmayemir
Copy link

There are no examples or docs on specifying only the service name in matching rules like so:

  rules:
    - matches:
        - method:
            service: package.name.version.Service

There is a matching rule example for when you match by service name and header value, but nothing for arguably the most common use case of routing by only the service name.

@rauanmayemir rauanmayemir added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 30, 2024
@Nishant-k-sagar
Copy link

@rauanmayemir can you explain this issue little more, like what documentation updation are needed?

@rauanmayemir
Copy link
Author

@Nishant-k-sagar currently it makes it look like I can't specify routes that will match only by the serviceName. It may seem trivial, but it is the most obvious use case and not having it as a first basic example is surprising to me.

It's like if HTTPRoute didn't have examples for /user and only had a list of /user/login, /user/logout, /user/profile, that would lead to wondering if I can group match or do I have to write out all the possible endpoints.

Maybe it's unrelated, but cilium implementation does not support the way to do it: cilium/cilium#34079

@shaneutt shaneutt added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 20, 2024
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Status: Triage
Development

No branches or pull requests

3 participants